2020-02-05 01:25:37

by Karthikeyan periyasamy

Subject: [PATCH] ath11k: fix rcu lock protect in peer assoc confirmation

ath11k_mac_get_ar_by_vdev_id() get protected under rcu lock
and unlock. peer association confirmation event get used this API
without rcu protection, so corrected it.

Signed-off-by: Karthikeyan Periyasamy <[email protected]>
---
drivers/net/wireless/ath/ath11k/wmi.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index a9b301c..9cbe038d 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -5345,15 +5345,18 @@ static void ath11k_peer_assoc_conf_event(struct ath11k_base *ab, struct sk_buff
"peer assoc conf ev vdev id %d macaddr %pM\n",
peer_assoc_conf.vdev_id, peer_assoc_conf.macaddr);

+ rcu_read_lock();
ar = ath11k_mac_get_ar_by_vdev_id(ab, peer_assoc_conf.vdev_id);

if (!ar) {
ath11k_warn(ab, "invalid vdev id in peer assoc conf ev %d",
peer_assoc_conf.vdev_id);
+ rcu_read_unlock();
return;
}

complete(&ar->peer_assoc_done);
+ rcu_read_unlock();
}

static void ath11k_update_stats_event(struct ath11k_base *ab, struct sk_buff *skb)
--
1.9.1

2020-02-11 21:35:46

by Kalle Valo

Subject: Re: [PATCH] ath11k: fix rcu lock protect in peer assoc confirmation

Karthikeyan Periyasamy <[email protected]> wrote:

> ath11k_mac_get_ar_by_vdev_id() get protected under rcu lock
> and unlock. peer association confirmation event get used this API
> without rcu protection, so corrected it.
>
> Signed-off-by: Karthikeyan Periyasamy <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

db0889aba262 ath11k: fix rcu lock protect in peer assoc confirmation

--
https://patchwork.kernel.org/patch/11365669/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches