2020-02-19 04:16:37

by chenqiwu

Subject: [PATCH] b43legacy/sysfs.c: replace simple_strtol() with kstrtoint()

From: chenqiwu <[email protected]>

The simple_strtol() function is deprecated since it does not
check for the range overflow. Use kstrtoint() instead.

Signed-off-by: chenqiwu <[email protected]>
---
drivers/net/wireless/broadcom/b43legacy/sysfs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/sysfs.c b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
index 9312c1d..eec087c 100644
--- a/drivers/net/wireless/broadcom/b43legacy/sysfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
@@ -25,13 +25,15 @@
static int get_integer(const char *buf, size_t count)
{
char tmp[10 + 1] = { 0 };
- int ret = -EINVAL;
+ int ret = -EINVAL, res;

if (count == 0)
goto out;
count = min_t(size_t, count, 10);
memcpy(tmp, buf, count);
- ret = simple_strtol(tmp, NULL, 10);
+ ret = kstrtoint(tmp, 10, &res);
+ if (!ret)
+ return res;
out:
return ret;
}
--
1.9.1

2020-03-12 13:42:41

by Kalle Valo

Subject: Re: [PATCH] b43legacy: replace simple_strtol() with kstrtoint()

[email protected] wrote:

> From: chenqiwu <[email protected]>
>
> The simple_strtol() function is deprecated since it does not
> check for the range overflow. Use kstrtoint() instead.
>
> Signed-off-by: chenqiwu <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

871b4b48cdbf b43legacy: replace simple_strtol() with kstrtoint()

--
https://patchwork.kernel.org/patch/11390321/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches