2020-09-24 11:59:25

by Govind Singh

Subject: [PATCH] ath11k: Move non-fatal warn logs to dbg level

During driver load below warn logs are printed in the console.
Since driver may not implement all wmi events sent by fw and
all of them are non-fatal, move this log to debug level to
remove un-necessary warn message on console.

[876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
[879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a

No functional changes. Compile tested only.

Signed-off-by: Govind Singh <[email protected]>
---
drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index adde14a390ec..1e5a46bdaa61 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -6579,7 +6579,7 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
break;
/* TODO: Add remaining events */
default:
- ath11k_warn(ab, "Unknown eventid: 0x%x\n", id);
+ ath11k_dbg(ab, ATH11K_DBG_WMI, "Unknown eventid: 0x%x\n", id);
break;
}

--
2.22.0

2020-09-29 08:33:15

by Kalle Valo

Subject: Re: [PATCH] ath11k: Move non-fatal warn logs to dbg level

Govind Singh <[email protected]> wrote:

> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
>
> [876.898735] ath11k_pci 0000:06:00.0: Unknown eventid: 0x16005
> [879.283250] ath11k_pci 0000:06:00.0: Unknown eventid: 0x1d00a
>
> No functional changes. Compile tested only.
>
> Signed-off-by: Govind Singh <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

82b4f9b857e7 ath11k: Move non-fatal warn logs to dbg level

--
https://patchwork.kernel.org/patch/11797129/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches