2020-11-11 10:40:09

by Maharaja Kennadyrajan

Subject: [PATCH v2] ath11k: Fix the rx_filter flag setting for peer rssi stats

Set the rx_filter in ath11k_mac_config_mon_status_default(),
only when the rx_filter value exists in ath11k_debug_rx_filter().

Without this change, rx_filter gets set to 0 and peer rssi stats
aren't updating properly from firmware.

Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01230-QCAHKSWPL_SILICONZ-4

Fixes: ec48d28ba291 ("ath11k: Fix rx_filter flags setting for per peer rx_stats")

Signed-off-by: Maharaja Kennadyrajan <[email protected]>
---

V2: Added the "Fixes" tag in the commit message.

drivers/net/wireless/ath/ath11k/mac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 591dceb..cad4402 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4144,7 +4144,8 @@ static int ath11k_mac_config_mon_status_default(struct ath11k *ar, bool enable)

if (enable) {
tlv_filter = ath11k_mac_mon_status_filter_default;
- tlv_filter.rx_filter = ath11k_debugfs_rx_filter(ar);
+ if (ath11k_debugfs_rx_filter(ar))
+ tlv_filter.rx_filter = ath11k_debugfs_rx_filter(ar);
}

for (i = 0; i < ab->hw_params.num_rxmda_per_pdev; i++) {
--
2.7.4

2020-11-23 18:09:15

by Kalle Valo

Subject: Re: [PATCH v2] ath11k: Fix the rx_filter flag setting for peer rssi stats

Maharaja Kennadyrajan <[email protected]> wrote:

> Set the rx_filter in ath11k_mac_config_mon_status_default(),
> only when the rx_filter value exists in ath11k_debug_rx_filter().
>
> Without this change, rx_filter gets set to 0 and peer rssi stats
> aren't updating properly from firmware.
>
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01230-QCAHKSWPL_SILICONZ-4
>
> Fixes: ec48d28ba291 ("ath11k: Fix rx_filter flags setting for per peer rx_stats")
>
> Signed-off-by: Maharaja Kennadyrajan <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

11af6de4799e ath11k: Fix the rx_filter flag setting for peer rssi stats

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches