2021-10-19 12:49:16

by Geert Uytterhoeven

Subject: [PATCH] net: wlcore: spi: Use dev_err_probe()

Use the existing dev_err_probe() helper instead of open-coding the same
operation.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Compile-tested only.
---
drivers/net/wireless/ti/wlcore/spi.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index f26fc150ecd01460..354a7e1c3315c6e2 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -488,12 +488,9 @@ static int wl1271_probe(struct spi_device *spi)
spi->bits_per_word = 32;

glue->reg = devm_regulator_get(&spi->dev, "vwlan");
- if (PTR_ERR(glue->reg) == -EPROBE_DEFER)
- return -EPROBE_DEFER;
- if (IS_ERR(glue->reg)) {
- dev_err(glue->dev, "can't get regulator\n");
- return PTR_ERR(glue->reg);
- }
+ if (IS_ERR(glue->reg))
+ return dev_err_probe(glue->dev, PTR_ERR(glue->reg),
+ "can't get regulator\n");

ret = wlcore_probe_of(spi, glue, pdev_data);
if (ret) {
--
2.25.1

2021-10-27 18:51:49

by Kalle Valo

Subject: Re: wlcore: spi: Use dev_err_probe()

Geert Uytterhoeven <[email protected]> wrote:

> Use the existing dev_err_probe() helper instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

1aa3367ca78c wlcore: spi: Use dev_err_probe()

--
https://patchwork.kernel.org/project/linux-wireless/patch/465e76901b801ac0755088998249928fd546c08a.1634647460.git.geert+renesas@glider.be/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches