2022-10-10 03:36:07

by Baochen Qiang

Subject: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold

We are seeing system stuck on some specific platforms due to
WLAN chip fails to wakeup from D3cold state.

With this flag, firmware will send PME message during wakeup
and this issue is gone.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3

Signed-off-by: Baochen Qiang <[email protected]>
---
drivers/net/wireless/ath/ath11k/qmi.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 84e3abecbdac..145f20a681bd 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -19,6 +19,7 @@
#define SLEEP_CLOCK_SELECT_INTERNAL_BIT 0x02
#define HOST_CSTATE_BIT 0x04
#define PLATFORM_CAP_PCIE_GLOBAL_RESET 0x08
+#define PLATFORM_CAP_PCIE_PME_D3COLD 0x10

#define FW_BUILD_ID_MASK "QC_IMAGE_VERSION_STRING="

@@ -1752,6 +1753,8 @@ static int ath11k_qmi_host_cap_send(struct ath11k_base *ab)
if (ab->hw_params.global_reset)
req.nm_modem |= PLATFORM_CAP_PCIE_GLOBAL_RESET;

+ req.nm_modem |= PLATFORM_CAP_PCIE_PME_D3COLD;
+
ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi host cap request\n");

ret = qmi_txn_init(&ab->qmi.handle, &txn,

base-commit: 023baf1318ef21442fab3842bf03883bc81223e0
--
2.25.1

2022-10-11 07:53:01

by Kalle Valo

Subject: Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold

Baochen Qiang <[email protected]> wrote:

> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3

The firmware you are using is old, please update to the latest one:

https://github.com/kvalo/ath11k-firmware/tree/master/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.16

It's very important that the testing happens on latest components.

No need to resend because of this.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-10-12 06:53:26

by Kalle Valo

Subject: Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold

Baochen Qiang <[email protected]> wrote:

> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Signed-off-by: Baochen Qiang <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

3f9b09ccf7d5 wifi: ath11k: Send PME message during wakeup from D3cold

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches