2023-09-28 15:56:57

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()

Dmitry Antipov <[email protected]> wrote:

> Since 'srng_list' is a fixed-size array of 'struct hal_srng'
> in 'struct ath11_hal', any of its member can't be NULL and
> so relevant check may be dropped.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <[email protected]>

Failed to apply.

error: patch failed: drivers/net/wireless/ath/ath11k/dp_rx.c:5094
error: drivers/net/wireless/ath/ath11k/dp_rx.c: patch does not apply
stg import: Diff does not apply cleanly

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2023-09-30 02:07:15

by Dmitry Antipov

[permalink] [raw]
Subject: Re: [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_dp_rx_mon_dest_process()

On 9/28/23 18:46, Kalle Valo wrote:

> Patch set to Changes Requested.

Probably I miss something around your internal ath-specific workflow
but AFAICS this fix is not needed for ath-next branch of ath.git
(there is no redundant NULL pointer check there).

Dmitry