2023-10-12 22:09:07

by Randy Dunlap

Subject: [PATCH] ssb: relax SSB_EMBEDDED dependencies

This is a kconfig warning in a randconfig when CONFIG_PCI is not set:

WARNING: unmet direct dependencies detected for SSB_EMBEDDED
Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n]
Selected by [y]:
- BCM47XX_SSB [=y] && BCM47XX [=y]

This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB
selecting SSB_EMBEDDED when CONFIG_PCI is not set.

This warning can be prevented by altering SSB_EMBEDDED to allow for
PCI=n or the former SSB_PCICORE_HOSTMODE.

Signed-off-by: Randy Dunlap <[email protected]>
Acked-by: Michael Büsch <[email protected]>
Cc: [email protected]
Cc: Kalle Valo <[email protected]>
---
drivers/ssb/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff -- a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -134,7 +134,8 @@ config SSB_SFLASH
# Assumption: We are on embedded, if we compile the MIPS core.
config SSB_EMBEDDED
bool
- depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
+ depends on SSB_DRIVER_MIPS
+ depends on PCI=n || SSB_PCICORE_HOSTMODE
default y

config SSB_DRIVER_EXTIF

2023-10-19 07:27:15

by Kalle Valo

Subject: Re: [PATCH] ssb: relax SSB_EMBEDDED dependencies

Randy Dunlap <[email protected]> wrote:

> This is a kconfig warning in a randconfig when CONFIG_PCI is not set:
>
> WARNING: unmet direct dependencies detected for SSB_EMBEDDED
> Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n]
> Selected by [y]:
> - BCM47XX_SSB [=y] && BCM47XX [=y]
>
> This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB
> selecting SSB_EMBEDDED when CONFIG_PCI is not set.
>
> This warning can be prevented by altering SSB_EMBEDDED to allow for
> PCI=n or the former SSB_PCICORE_HOSTMODE.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Acked-by: Michael Büsch <[email protected]>
> Cc: [email protected]
> Cc: Kalle Valo <[email protected]>

Patch applied to wireless-next.git, thanks.

a86a8ca798e9 ssb: relax SSB_EMBEDDED dependencies

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches