2023-12-04 09:14:32

by Weng Lin Puah

Subject: [PATCH] wifi: ath12k: fix wrong definition of ath12k_hw_ring_mask_qcn9274

ath12k_hw_ring_mask_qcn9274.tx[3] does not match with its counterpart
wbm_ring_num. This will cause the corresponding
ath12k_dp_tx_completion_handler is not entered. Thus, some of the dma
memory is not free and eventually runs out of the dma memory.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.2.1-00148-QCAHKSWPL_SILICONZ-1

Signed-off-by: WL Puah <[email protected]>

---
drivers/net/wireless/ath/ath12k/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/hw.c
b/drivers/net/wireless/ath/ath12k/hw.c
index ea3eda1f1948..2b35c8aa6273 100644
--- a/drivers/net/wireless/ath/ath12k/hw.c
+++ b/drivers/net/wireless/ath/ath12k/hw.c
@@ -536,7 +536,7 @@ static const struct ath12k_hw_ring_mask
ath12k_hw_ring_mask_qcn9274 = {
ATH12K_TX_RING_MASK_0,
ATH12K_TX_RING_MASK_1,
ATH12K_TX_RING_MASK_2,
- ATH12K_TX_RING_MASK_3,
+ ATH12K_TX_RING_MASK_4,
},
.rx_mon_dest = {
0, 0, 0,
--
2.34.1

2024-03-12 15:52:26

by Kalle Valo

Subject: Re: [PATCH] wifi: ath12k: fix wrong definition of ath12k_hw_ring_mask_qcn9274

Weng Lin Puah <[email protected]> wrote:

> ath12k_hw_ring_mask_qcn9274.tx[3] does not match with its counterpart
> wbm_ring_num. This will cause the corresponding
> ath12k_dp_tx_completion_handler is not entered. Thus, some of the dma
> memory is not free and eventually runs out of the dma memory.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.2.1-00148-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: WL Puah <[email protected]>

>From and s-o-b don't match (gmail.com vs compex.com.sg)

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/CAD73Kh8_Ks0Fb6EsG6ks0oKKONfwr98uRccV5bbmEb15PLPvow@mail.gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches