2024-05-15 15:34:12

by Dmitry Antipov

Subject: [PATCH] rt2x00: remove unused delayed work data from link description

Remove unused 'agc_work' and 'vco_work' members of 'struct link'.
This follows commit d96324703ffa ("rt2x00: merge agc and vco works
with link tuner") where AGC and VCO calibration code was completely
redesigned. Compile tested only.

Signed-off-by: Dmitry Antipov <[email protected]>
---
drivers/net/wireless/ralink/rt2x00/rt2x00.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
index 82af01448a0a..bb648f95dfdd 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
@@ -335,16 +335,6 @@ struct link {
struct delayed_work watchdog_work;
unsigned int watchdog_interval;
unsigned int watchdog;
-
- /*
- * Work structure for scheduling periodic AGC adjustments.
- */
- struct delayed_work agc_work;
-
- /*
- * Work structure for scheduling periodic VCO calibration.
- */
- struct delayed_work vco_work;
};

enum rt2x00_delayed_flags {
--
2.45.0

2024-05-18 09:39:46

by Stanislaw Gruszka

Subject: Re: [PATCH] rt2x00: remove unused delayed work data from link description

On Wed, May 15, 2024 at 06:28:24PM +0300, Dmitry Antipov wrote:
> Remove unused 'agc_work' and 'vco_work' members of 'struct link'.
> This follows commit d96324703ffa ("rt2x00: merge agc and vco works
> with link tuner") where AGC and VCO calibration code was completely
> redesigned. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <[email protected]>

Acked-by: Stanislaw Gruszka <[email protected]>


> ---
> drivers/net/wireless/ralink/rt2x00/rt2x00.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
> index 82af01448a0a..bb648f95dfdd 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
> @@ -335,16 +335,6 @@ struct link {
> struct delayed_work watchdog_work;
> unsigned int watchdog_interval;
> unsigned int watchdog;
> -
> - /*
> - * Work structure for scheduling periodic AGC adjustments.
> - */
> - struct delayed_work agc_work;
> -
> - /*
> - * Work structure for scheduling periodic VCO calibration.
> - */
> - struct delayed_work vco_work;
> };
>
> enum rt2x00_delayed_flags {
> --
> 2.45.0
>

2024-05-20 05:06:12

by Kalle Valo

Subject: Re: wifi: rt2x00: remove unused delayed work data from link description

Dmitry Antipov <[email protected]> wrote:

> Remove unused 'agc_work' and 'vco_work' members of 'struct link'.
> This follows commit d96324703ffa ("rt2x00: merge agc and vco works
> with link tuner") where AGC and VCO calibration code was completely
> redesigned. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <[email protected]>
> Acked-by: Stanislaw Gruszka <[email protected]>

Patch applied to wireless-next.git, thanks.

2785ea9673a7 wifi: rt2x00: remove unused delayed work data from link description

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches