> -----Original Message-----
> From: Dmitry Antipov <[email protected]>
> Sent: Tuesday, October 24, 2023 10:32 PM
> To: Ping-Ke Shih <[email protected]>
> Cc: Kalle Valo <[email protected]>; [email protected]; Dmitry Antipov <[email protected]>
> Subject: [PATCH] wifi: rtw89: fix timeout calculation in rtw89_roc_end()
>
> Since 'rtw89_core_tx_kick_off_and_wait()' assumes timeout
> (actually RTW89_ROC_TX_TIMEOUT) in milliseconds, I suppose
> that RTW89_ROC_IDLE_TIMEOUT is in milliseconds as well. If
> so, 'msecs_to_jiffies()' should be used in a call to
> 'ieee80211_queue_delayed_work()' from 'rtw89_roc_end()'.
> Compile tested only.
>
> Signed-off-by: Dmitry Antipov <[email protected]>
Thanks for the finding.
Acked-by: Ping-Ke Shih <[email protected]>
> ---
> drivers/net/wireless/realtek/rtw89/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
> index 4bfb4188de72..15196f07b5c0 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.c
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -2886,7 +2886,7 @@ void rtw89_roc_end(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwvif)
>
> if (hw->conf.flags & IEEE80211_CONF_IDLE)
> ieee80211_queue_delayed_work(hw, &roc->roc_work,
> - RTW89_ROC_IDLE_TIMEOUT);
> + msecs_to_jiffies(RTW89_ROC_IDLE_TIMEOUT));
> }
>
> void rtw89_roc_work(struct work_struct *work)
> --
> 2.41.0