2024-03-29 23:53:01

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH 5/7] wifi: brcm80211: drop driver owner initialization

On March 29, 2024 6:24:57 PM Krzysztof Kozlowski
<[email protected]> wrote:

> Core in sdio_register_driver() already sets the .owner, so driver does
> not need to.

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Depends on the first patch.
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> index 00679a990e3d..13391c2d82aa 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -1238,7 +1238,6 @@ static struct sdio_driver brcmf_sdmmc_driver = {
> .name = KBUILD_MODNAME,
> .id_table = brcmf_sdmmc_ids,
> .drv = {
> - .owner = THIS_MODULE,
> .pm = pm_sleep_ptr(&brcmf_sdio_pm_ops),
> .coredump = brcmf_dev_coredump,
> },
>
> --
> 2.34.1




Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature