2009-12-14 09:29:12

by Sujith

Subject: [PATCH 3/6] ath9k: Stop ANI when doing a reset

The MIB counters are disabled when doing a reset,
disable ANI to handle this case.

Cc: [email protected]
Signed-off-by: Sujith <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index c487434..9e68c1a 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1973,6 +1973,9 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
struct ieee80211_hw *hw = sc->hw;
int r;

+ /* Stop ANI */
+ del_timer_sync(&common->ani.timer);
+
ath9k_hw_set_interrupts(ah, 0);
ath_drain_all_txq(sc, retry_tx);
ath_stoprecv(sc);
@@ -2014,6 +2017,9 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
}
}

+ /* Start ANI */
+ ath_start_ani(common);
+
return r;
}

--
1.6.5.6

2009-12-14 11:01:51

by Sujith

Subject: Re: [PATCH 3/6] ath9k: Stop ANI when doing a reset

Kalle Valo wrote:
> The visible change to the user is good to explain. Was there packet
> loss, did the kernel crash or what?

Sub-optimal performance would be the visible impact.

Updated patch will follow momentarily.
Thanks for the review.

Sujith

2009-12-14 10:17:21

by Kalle Valo

Subject: Re: [PATCH 3/6] ath9k: Stop ANI when doing a reset

Sujith <[email protected]> writes:

> The MIB counters are disabled when doing a reset,
> disable ANI to handle this case.

The visible change to the user is good to explain. Was there packet
loss, did the kernel crash or what?

--
Kalle Valo