2010-03-29 22:20:10

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> Thanks so much for this driver, it's working flawlessly. Only one minor problem
> was "Michael MIC failure detected", changing to AES helped.

Not sure if Sujith's patch posted yesterday would fix this.

> I don't know if what I've done is correct, in order to recognize my card
> (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> "#define AR9271_USB 0x1006", is this the right thing to do ?

Sort of, try this patch:

From: Luis R. Rodriguez <[email protected]>
Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID

Reported-by: Wiktor Zajas <[email protected]>
Signed-off-by: Luis R. Rodriguez <[email protected]>
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index fc4f6e8..a7664e4 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -21,6 +21,7 @@

static struct usb_device_id ath9k_hif_usb_ids[] = {
ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
+ ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */
{ },
};

--
1.6.3.3


********************************************************************************
Git Achievement Unlocked!

Apprentice Archivist (Level 3)
Prepare each commit with its patch in one file per commit with git format-patch
********************************************************************************



2010-04-20 16:00:19

by John W. Linville

[permalink] [raw]
Subject: Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

On Mon, Mar 29, 2010 at 03:20:08PM -0700, Luis R. Rodriguez wrote:
> On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> > Thanks so much for this driver, it's working flawlessly. Only one minor problem
> > was "Michael MIC failure detected", changing to AES helped.
>
> Not sure if Sujith's patch posted yesterday would fix this.
>
> > I don't know if what I've done is correct, in order to recognize my card
> > (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> > "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> > "#define AR9271_USB 0x1006", is this the right thing to do ?
>
> Sort of, try this patch:
>
> From: Luis R. Rodriguez <[email protected]>
> Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID
>
> Reported-by: Wiktor Zajas <[email protected]>
> Signed-off-by: Luis R. Rodriguez <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index fc4f6e8..a7664e4 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -21,6 +21,7 @@
>
> static struct usb_device_id ath9k_hif_usb_ids[] = {
> ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
> + ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */
> { },
> };

Any feedback on this?

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2010-04-21 13:00:16

by John W. Linville

[permalink] [raw]
Subject: Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

On Wed, Apr 21, 2010 at 07:38:12AM +0530, Sujith wrote:
> John W. Linville wrote:
> > Any feedback on this?
>
> This has already been merged.
>
> commit e92119ca88691ac2239916d31c3dcecd10867521
> Author: Sujith <[email protected]>
> Date: Thu Apr 1 10:28:24 2010 +0530
>
> ath9k_htc: Add TL-WN422G v2 product ID
>
> Signed-off-by: Sujith <[email protected]>
> Signed-off-by: John W. Linville <[email protected]>

:-) OK, thanks!

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2010-04-21 02:08:41

by Sujith

[permalink] [raw]
Subject: Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

John W. Linville wrote:
> Any feedback on this?

This has already been merged.

commit e92119ca88691ac2239916d31c3dcecd10867521
Author: Sujith <[email protected]>
Date: Thu Apr 1 10:28:24 2010 +0530

ath9k_htc: Add TL-WN422G v2 product ID

Signed-off-by: Sujith <[email protected]>
Signed-off-by: John W. Linville <[email protected]>


Sujith

2010-04-20 17:36:18

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now

On Tue, Apr 20, 2010 at 08:45:44AM -0700, John W. Linville wrote:
> On Mon, Mar 29, 2010 at 03:20:08PM -0700, Luis R. Rodriguez wrote:
> > On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> > > Thanks so much for this driver, it's working flawlessly. Only one minor problem
> > > was "Michael MIC failure detected", changing to AES helped.
> >
> > Not sure if Sujith's patch posted yesterday would fix this.
> >
> > > I don't know if what I've done is correct, in order to recognize my card
> > > (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> > > "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> > > "#define AR9271_USB 0x1006", is this the right thing to do ?
> >
> > Sort of, try this patch:
> >
> > From: Luis R. Rodriguez <[email protected]>
> > Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID
> >
> > Reported-by: Wiktor Zajas <[email protected]>
> > Signed-off-by: Luis R. Rodriguez <[email protected]>
> > ---
> > drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> > index fc4f6e8..a7664e4 100644
> > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> > @@ -21,6 +21,7 @@
> >
> > static struct usb_device_id ath9k_hif_usb_ids[] = {
> > ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
> > + ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */

This patch was wrong, Sujith was going to fix it, I think he sent
some followups. If not we'll take care of it.

Luis