2010-06-17 09:26:57

by Sujith

[permalink] [raw]
Subject: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Signed-off-by: Sujith <[email protected]>
---
drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 ++-
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 +++
2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
index 148b433..e1840b1 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
@@ -700,7 +700,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,

hw->wiphy->interface_modes =
BIT(NL80211_IFTYPE_STATION) |
- BIT(NL80211_IFTYPE_ADHOC);
+ BIT(NL80211_IFTYPE_ADHOC) |
+ BIT(NL80211_IFTYPE_AP);

hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index 05445d8..2869cff 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -1283,6 +1283,9 @@ static int ath9k_htc_add_interface(struct ieee80211_hw *hw,
case NL80211_IFTYPE_ADHOC:
hvif.opmode = cpu_to_be32(HTC_M_IBSS);
break;
+ case NL80211_IFTYPE_AP:
+ hvif.opmode = cpu_to_be32(HTC_M_HOSTAP);
+ break;
default:
ath_print(common, ATH_DBG_FATAL,
"Interface type %d not yet supported\n", vif->type);
--
1.7.1



2010-06-17 18:03:30

by Sujith

[permalink] [raw]
Subject: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Hi,

BTW, these are RFC patches.
So John, you can skip these and resume the tiresome work of saving the world.
We superheroes have lots of shite to do.

Sujith

Sujith wrote:
> Signed-off-by: Sujith <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 ++-
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 +++
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> index 148b433..e1840b1 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> @@ -700,7 +700,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
>
> hw->wiphy->interface_modes =
> BIT(NL80211_IFTYPE_STATION) |
> - BIT(NL80211_IFTYPE_ADHOC);
> + BIT(NL80211_IFTYPE_ADHOC) |
> + BIT(NL80211_IFTYPE_AP);
>
> hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index 05445d8..2869cff 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -1283,6 +1283,9 @@ static int ath9k_htc_add_interface(struct ieee80211_hw *hw,
> case NL80211_IFTYPE_ADHOC:
> hvif.opmode = cpu_to_be32(HTC_M_IBSS);
> break;
> + case NL80211_IFTYPE_AP:
> + hvif.opmode = cpu_to_be32(HTC_M_HOSTAP);
> + break;
> default:
> ath_print(common, ATH_DBG_FATAL,
> "Interface type %d not yet supported\n", vif->type);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2010-06-18 16:33:55

by Pavel Roskin

[permalink] [raw]
Subject: Re: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

On Thu, 2010-06-17 at 14:58 +0530, Sujith wrote:
> Signed-off-by: Sujith <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 ++-
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 +++
> 2 files changed, 5 insertions(+), 1 deletions(-)

I confirm that the AP mode is working on TP-Link TL-WN422G (0cf3:1006).
I tested both patched of the series at once.

That's great news! TL-WN422G has an external antenna, connects over USB
and supports AP mode. Users keep asking about that combination of
features. Now we have an answer :-)

--
Regards,
Pavel Roskin

2010-06-25 09:31:13

by Sujith

[permalink] [raw]
Subject: Re: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Pavel Roskin wrote:
> On Thu, 2010-06-17 at 14:58 +0530, Sujith wrote:
> > Signed-off-by: Sujith <[email protected]>
> > ---
> > drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 ++-
> > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 +++
> > 2 files changed, 5 insertions(+), 1 deletions(-)
>
> I confirm that the AP mode is working on TP-Link TL-WN422G (0cf3:1006).
> I tested both patched of the series at once.
>
> That's great news! TL-WN422G has an external antenna, connects over USB
> and supports AP mode. Users keep asking about that combination of
> features. Now we have an answer :-)
>

Thanks for testing, the buffering patch is a bit buggy.
Will send out updated patches doing things properly.

Sujith

2010-07-31 18:22:33

by Sujith

[permalink] [raw]
Subject: Re: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Kalle Valo wrote:
> Sorry for a late reply, I'm really backlogged :)
>
> > I confirm that the AP mode is working on TP-Link TL-WN422G (0cf3:1006).
> > I tested both patched of the series at once.
> >
> > That's great news! TL-WN422G has an external antenna, connects over USB
> > and supports AP mode. Users keep asking about that combination of
> > features. Now we have an answer :-)
>
> Cool, this would be really handy for testing wireless clients. Does it
> also support proper multicast/broadcast buffering?

Nope, the firmware lacks CAB queue support, which is required for PS buffering
in Atheros' chipsets. Which is exactly why those patches were dropped. :(

Sujith

2010-07-31 08:41:43

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Sorry for a late reply, I'm really backlogged :)

> I confirm that the AP mode is working on TP-Link TL-WN422G (0cf3:1006).
> I tested both patched of the series at once.
>
> That's great news! TL-WN422G has an external antenna, connects over USB
> and supports AP mode. Users keep asking about that combination of
> features. Now we have an answer :-)

Cool, this would be really handy for testing wireless clients. Does it
also support proper multicast/broadcast buffering?

--
Kalle Valo

2010-07-31 19:00:59

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 1/2] ath9k_htc: Add AP mode to supported modes

Sujith <[email protected]> writes:

> Kalle Valo wrote:
>>
>> > I confirm that the AP mode is working on TP-Link TL-WN422G (0cf3:1006).
>> > I tested both patched of the series at once.
>> >
>> > That's great news! TL-WN422G has an external antenna, connects over USB
>> > and supports AP mode. Users keep asking about that combination of
>> > features. Now we have an answer :-)
>>
>> Cool, this would be really handy for testing wireless clients. Does it
>> also support proper multicast/broadcast buffering?
>
> Nope, the firmware lacks CAB queue support, which is required for PS
> buffering in Atheros' chipsets. Which is exactly why those patches
> were dropped. :(

I was just afraid of this. Oh well, AP support, USB and cheap sounded
like an impossible combination :/

Thank you for letting me know.

--
Kalle Valo