2023-07-19 16:39:03

by hanyu001

Subject: [PATCH] rtlwifi: rtl8192ee: phy Remove unnecessary spaces

Fix checkpatch warnings:

./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:742: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:766: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:766: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:771: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:771: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:927: ERROR: space
prohibited before that ',' (ctx:WxW)
./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:974: ERROR: space
prohibited before that ',' (ctx:WxW)

Signed-off-by: Yu Han <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
index cc0bcaf..d4b6131 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
@@ -739,7 +739,7 @@ static bool phy_config_bb_with_hdr_file(struct
ieee80211_hw *hw,
if (i >= len - 2)
break;

- if (!_check_condition(hw , array[i])) {
+ if (!_check_condition(hw, array[i])) {
/*Discard the following pairs*/
READ_NEXT_PAIR(v1, v2, i);
while (v2 != 0xDEAD &&
@@ -763,12 +763,12 @@ static bool phy_config_bb_with_hdr_file(struct
ieee80211_hw *hw,
MASKDWORD,
array[i + 1]);
udelay(1);
- READ_NEXT_PAIR(v1 , v2 , i);
+ READ_NEXT_PAIR(v1, v2, i);
}

while (v2 != 0xDEAD &&
i < len - 2) {
- READ_NEXT_PAIR(v1 , v2 , i);
+ READ_NEXT_PAIR(v1, v2, i);
}
}
}
@@ -924,7 +924,7 @@ bool rtl92ee_phy_config_rf_with_headerfile(struct
ieee80211_hw *hw,
if (i >= len - 2)
break;

- if (!_check_condition(hw , array[i])) {
+ if (!_check_condition(hw, array[i])) {
/*Discard the following pairs*/
READ_NEXT_RF_PAIR(v1, v2, i);
while (v2 != 0xDEAD &&
@@ -971,7 +971,7 @@ bool rtl92ee_phy_config_rf_with_headerfile(struct
ieee80211_hw *hw,
if (i >= len - 2)
break;

- if (!_check_condition(hw , array[i])) {
+ if (!_check_condition(hw, array[i])) {
/*Discard the following pairs*/
READ_NEXT_RF_PAIR(v1, v2, i);
while (v2 != 0xDEAD &&

2023-07-20 00:17:28

by Ping-Ke Shih

Subject: RE: [PATCH] rtlwifi: rtl8192ee: phy Remove unnecessary spaces

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Wednesday, July 19, 2023 5:43 PM
> To: Ping-Ke Shih <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH] rtlwifi: rtl8192ee: phy Remove unnecessary spaces

Subject should be "wifi: rtlwifi: ...".

You can check the subject pattern by git log, like:

$ git log --oneline drivers/net/wireless/realtek/rtlwifi
fef0f427f7122 wifi: rtlwifi: remove misused flag from HAL data
557123259200b wifi: rtlwifi: remove unused dualmac control leftovers
358b94f0a7cad wifi: rtlwifi: remove unused timer and related code
3e450386e99e6 wifi: rtlwifi: use helper function rtl_get_hdr()
5dbe1f8eb8c5a wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()
905a9241e4e8c wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()
82d6077901c67 wifi: rtlwifi: Replace fake flex-array with flex-array member
ff6f38eb920bd wifi: rtlwifi: rtl8192se: Remove some unused variables
db5e4b3645534 wifi: rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable

>
> Fix checkpatch warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:742: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:766: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:766: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:771: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:771: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:927: ERROR: space
> prohibited before that ',' (ctx:WxW)
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:974: ERROR: space
> prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Yu Han <[email protected]>

Reviewed-by: Ping-Ke Shih <[email protected]>

[...]