2007-03-03 12:12:26

by Johannes Berg

[permalink] [raw]
Subject: straw poll: new Kconfig symbol for mac80211 debugfs?

After moving all the sysfs stuff to debugfs I notice that it is quite a
large amount of code. Does anybody think having a new Kconfig symbol for
that like this one

config MAC80211_DEBUGFS
bool "DebugFS support"
depends on MAC80211
---help---
Select this to see extensive information about
the internal state of mac80211 in debugfs.

Say N unless you know you need this.

would make sense?

johannes


Attachments:
signature.asc (190.00 B)
This is a digitally signed message part

2007-03-03 16:08:10

by Johannes Berg

[permalink] [raw]
Subject: Re: straw poll: new Kconfig symbol for mac80211 debugfs?

On Sat, 2007-03-03 at 07:51 -0800, Randy Dunlap wrote:
> On Sat, 03 Mar 2007 13:12:03 +0100 Johannes Berg wrote:
>
> > After moving all the sysfs stuff to debugfs I notice that it is quite a
> > large amount of code. Does anybody think having a new Kconfig symbol for
> > that like this one
> >
> > config MAC80211_DEBUGFS
> > bool "DebugFS support"
> > depends on MAC80211
> > ---help---
> > Select this to see extensive information about
> > the internal state of mac80211 in debugfs.
> >
> > Say N unless you know you need this.
> >
> > would make sense?
>
> Yes. But it should also depend on DEBUG_FS... (maybe it does
> that somewhere else?)

Yeah, I only wrote this right into this email and forgot (and when I
noticed seconds after sending I didn't want to spam everybody again,
sent enough mail already today :) )

johannes


Attachments:
signature.asc (190.00 B)
This is a digitally signed message part

2007-03-03 15:53:31

by Randy Dunlap

[permalink] [raw]
Subject: Re: straw poll: new Kconfig symbol for mac80211 debugfs?

On Sat, 03 Mar 2007 13:12:03 +0100 Johannes Berg wrote:

> After moving all the sysfs stuff to debugfs I notice that it is quite a
> large amount of code. Does anybody think having a new Kconfig symbol for
> that like this one
>
> config MAC80211_DEBUGFS
> bool "DebugFS support"
> depends on MAC80211
> ---help---
> Select this to see extensive information about
> the internal state of mac80211 in debugfs.
>
> Say N unless you know you need this.
>
> would make sense?

Yes. But it should also depend on DEBUG_FS... (maybe it does
that somewhere else?)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2007-03-03 17:30:06

by Michael Büsch

[permalink] [raw]
Subject: Re: straw poll: new Kconfig symbol for mac80211 debugfs?

On Saturday 03 March 2007 13:12, Johannes Berg wrote:
> After moving all the sysfs stuff to debugfs I notice that it is quite a
> large amount of code. Does anybody think having a new Kconfig symbol for
> that like this one
>
> config MAC80211_DEBUGFS
> bool "DebugFS support"
> depends on MAC80211
> ---help---
> Select this to see extensive information about
> the internal state of mac80211 in debugfs.
>
> Say N unless you know you need this.
>
> would make sense?

I'd say this doesn't make too much sense. Simply enable it
when CONFIG_D80211_DEBUG is set.

--
Greetings Michael.