2007-03-11 04:40:18

by Pavel Roskin

[permalink] [raw]
Subject: [PATCH] zd1211rw: sparse-annotate radiotap header

All fields in radiotap header must be little endian. The driver does it
correctly, but the structure definition must be annotated.

Signed-off-by: Pavel Roskin <[email protected]>
---

drivers/net/wireless/mac80211/zd1211rw/zd_mac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mac80211/zd1211rw/zd_mac.c b/drivers/net/wireless/mac80211/zd1211rw/zd_mac.c
index 5b9e04a..231ec2d 100644
--- a/drivers/net/wireless/mac80211/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/mac80211/zd1211rw/zd_mac.c
@@ -367,8 +367,8 @@ struct zd_rt_hdr {
struct ieee80211_radiotap_header rt_hdr;
u8 rt_flags;
u8 rt_rate;
- u16 rt_channel;
- u16 rt_chbitmask;
+ __le16 rt_channel;
+ __le16 rt_chbitmask;
} __attribute__((packed));

static void fill_rt_header(void *buffer, struct zd_mac *mac,




2007-03-11 12:50:58

by Ulrich Kunitz

[permalink] [raw]
Subject: Re: [PATCH] zd1211rw: sparse-annotate radiotap header

On 07-03-10 23:40 Pavel Roskin wrote:

> All fields in radiotap header must be little endian. The driver does it
> correctly, but the structure definition must be annotated.
>
> Signed-off-by: Pavel Roskin <[email protected]>
Acked-by: Ulrich Kunitz <[email protected]>

I have put the patch in the zd1211rw branch of my wireless-dev
git tree, which can be found under

http://www.deine-taler.de/zd1211/wireless-dev.git/

Cheers,

Uli

--
Uli Kunitz