2007-06-24 11:48:07

by Guy Cohen

[permalink] [raw]
Subject: wmm_acm setting

Hi,

In mac80211/ieee80211_sta.c, ieee80211_sta_wmm_params(), line ~267, is
wmm_acm setting for case 1 (BK) and case 0 (BE) right (and not swapped)?

Regards,
Guy.


switch (aci) {
case 1:
queue = IEEE80211_TX_QUEUE_DATA3;
if (acm) {
local->wmm_acm |= BIT(0) | BIT(3);
}
break;
case 2:
queue = IEEE80211_TX_QUEUE_DATA1;
if (acm) {
local->wmm_acm |= BIT(4) | BIT(5);
}
break;
case 3:
queue = IEEE80211_TX_QUEUE_DATA0;
if (acm) {
local->wmm_acm |= BIT(6) | BIT(7);
}
break;
case 0:
default:
queue = IEEE80211_TX_QUEUE_DATA2;
if (acm) {
local->wmm_acm |= BIT(1) | BIT(2);
}
break;
}



2007-07-07 15:39:08

by Jiri Benc

[permalink] [raw]
Subject: Re: wmm_acm setting

On Thu, 5 Jul 2007 03:08:44 +0300, Tomas Winkler wrote:
> Somehow cannot find in wireless-dev.git
> Can you paste it into email.

http://git.kernel.org/?p=linux/kernel/git/linville/wireless-dev.git;a=commit;h=37c95ceeebd38a3f1f686b8fbf5168672d19f825

Jiri

--
Jiri Benc
SUSE Labs

2007-07-02 16:40:05

by Jiri Benc

[permalink] [raw]
Subject: Re: wmm_acm setting

On Sun, 24 Jun 2007 14:47:40 +0300, Cohen, Guy wrote:
> In mac80211/ieee80211_sta.c, ieee80211_sta_wmm_params(), line ~267, is
> wmm_acm setting for case 1 (BK) and case 0 (BE) right (and not swapped)?

See commit 37c95ceeebd38a3f1f686b8fbf5168672d19f825 in wireless-dev and
the referenced table.

Jiri

--
Jiri Benc
SUSE Labs

2007-07-05 00:08:46

by Tomas Winkler

[permalink] [raw]
Subject: Re: wmm_acm setting

Somehow cannot find in wireless-dev.git
Can you paste it into email.
Thanks
Tomas

On 7/2/07, Jiri Benc <[email protected]> wrote:
> On Sun, 24 Jun 2007 14:47:40 +0300, Cohen, Guy wrote:
> > In mac80211/ieee80211_sta.c, ieee80211_sta_wmm_params(), line ~267, is
> > wmm_acm setting for case 1 (BK) and case 0 (BE) right (and not swapped)?
>
> See commit 37c95ceeebd38a3f1f686b8fbf5168672d19f825 in wireless-dev and
> the referenced table.
>
> Jiri
>
> --
> Jiri Benc
> SUSE Labs
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>