2007-07-09 22:35:28

by Jean Tourrilhes

Subject: [PATCH 2.6] SoftMAC : fix ESSID problem

Hi,

Victor Porton reported that the SoftMAC layer had random
problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686
After investigation, it turned out to be worse, the SoftMAC
layer is left in an inconsistent state. The fix is pretty trivial.
John : would you mind pushing that to 2.6.23 ?
Thanks...

Jean

Signed-off-by: Jean Tourrilhes <[email protected]>

-----------------------------------------------------------

--- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
+++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
@@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
*/
dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
- if (ieee80211softmac_start_scan(mac))
+ if (ieee80211softmac_start_scan(mac)) {
dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
+ mac->associnfo.associating = 0;
+ mac->associnfo.associated = 0;
+ }
goto out;
} else {
mac->associnfo.associating = 0;

2007-07-09 23:44:35

by Jean Tourrilhes

Subject: Re: [PATCH 2.6] SoftMAC : fix ESSID problem

On Mon, Jul 09, 2007 at 06:40:44PM -0500, Larry Finger wrote:
>
> This patch should also be sent to [email protected].

Please do so if you like it.

> Larry

Jean

2007-07-09 23:40:59

by Larry Finger

Subject: Re: [PATCH 2.6] SoftMAC : fix ESSID problem

Michael Buesch wrote:
> On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
>> Hi,
>>
>> Victor Porton reported that the SoftMAC layer had random
>> problem when setting the ESSID :
>> http://bugzilla.kernel.org/show_bug.cgi?id=8686
>> After investigation, it turned out to be worse, the SoftMAC
>> layer is left in an inconsistent state. The fix is pretty trivial.
>> John : would you mind pushing that to 2.6.23 ?
>> Thanks...
>>
>> Jean
>>
>> Signed-off-by: Jean Tourrilhes <[email protected]>
>>
>> -----------------------------------------------------------
>>
>> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
>> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
>> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
>> */
>> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
>> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
>> - if (ieee80211softmac_start_scan(mac))
>> + if (ieee80211softmac_start_scan(mac)) {
>> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
>> + mac->associnfo.associating = 0;
>> + mac->associnfo.associated = 0;
>> + }
>> goto out;
>> } else {
>> mac->associnfo.associating = 0;
>>
>
> Acked-by: Michael Buesch <[email protected]>
Acked-by: Larry Finger <[email protected]>

This patch should also be sent to [email protected].

Larry

2007-07-09 22:47:56

by Michael Büsch

Subject: Re: [PATCH 2.6] SoftMAC : fix ESSID problem

On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
> Hi,
>
> Victor Porton reported that the SoftMAC layer had random
> problem when setting the ESSID :
> http://bugzilla.kernel.org/show_bug.cgi?id=8686
> After investigation, it turned out to be worse, the SoftMAC
> layer is left in an inconsistent state. The fix is pretty trivial.
> John : would you mind pushing that to 2.6.23 ?
> Thanks...
>
> Jean
>
> Signed-off-by: Jean Tourrilhes <[email protected]>
>
> -----------------------------------------------------------
>
> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
> */
> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
> - if (ieee80211softmac_start_scan(mac))
> + if (ieee80211softmac_start_scan(mac)) {
> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
> + mac->associnfo.associating = 0;
> + mac->associnfo.associated = 0;
> + }
> goto out;
> } else {
> mac->associnfo.associating = 0;
>

Acked-by: Michael Buesch <[email protected]>


--
Greetings Michael.