2007-07-13 06:39:41

by Aurelien Jarno

Subject: Re: [patch 1/2] Merge the Sonics Silicon Backplane subsystem

On Thu, Jul 12, 2007 at 10:54:33AM +0200, [email protected] wrote:
> This merges the SSB subsystem. SSB is a backplane bus subsystem needed
> for various Broadcom devices.
>
> Signed-off-by: Michael Buesch <[email protected]>

[...]

> Index: linux-2.6/include/linux/ssb/ssb_regs.h
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6/include/linux/ssb/ssb_regs.h 2007-07-12 10:51:49.000000000 +0200
> @@ -0,0 +1,294 @@

[...]

> +#define SSB_EXTIF_BASE 0x1f000000 /* External Interface region base address */
> +#define SSB_FLASH1 0x1fc00000 /* Flash Region 1 */
> +#define SSB_FLASH1_SZ 0x00400000 /* Size of Flash Region 1 */
> +
> +#define SSB_PCI_DMA 0x40000000 /* Client Mode sb2pcitranslation2 (1 GB) */
> +#define SSB_PCI_DMA_SZ 0x40000000 /* Client Mode sb2pcitranslation2 size in bytes */
> +#define SSB_PCIE_DMA_L32 0x00000000 /* PCIE Client Mode sb2pcitranslation2 (2 ZettaBytes), low 32 bits */
> +#define SSB_PCIE_DMA_H32 0x80000000 /* PCIE Client Mode sb2pcitranslation2 (2 ZettaBytes), high 32 bits */
> +#define SSB_EUART (SB_EXTIF_BASE + 0x00800000)
> +#define SSB_LED (SB_EXTIF_BASE + 0x00900000)

I have just noticed a typo here. That should be SSB_EXTIF_BASE instead
of SB_EXTIF_BASE.

--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' [email protected] | [email protected]
`- people.debian.org/~aurel32 | http://www.aurel32.net

2007-07-13 10:24:00

by Michael Büsch

Subject: Re: [patch 1/2] Merge the Sonics Silicon Backplane subsystem

On Friday 13 July 2007 08:11:00 Aurelien Jarno wrote:
> On Thu, Jul 12, 2007 at 10:54:33AM +0200, [email protected] wrote:
> > This merges the SSB subsystem. SSB is a backplane bus subsystem needed
> > for various Broadcom devices.
> >
> > Signed-off-by: Michael Buesch <[email protected]>
>
> [...]
>
> > Index: linux-2.6/include/linux/ssb/ssb_regs.h
> > ===================================================================
> > --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> > +++ linux-2.6/include/linux/ssb/ssb_regs.h 2007-07-12 10:51:49.000000000 +0200
> > @@ -0,0 +1,294 @@
>
> [...]
>
> > +#define SSB_EXTIF_BASE 0x1f000000 /* External Interface region base address */
> > +#define SSB_FLASH1 0x1fc00000 /* Flash Region 1 */
> > +#define SSB_FLASH1_SZ 0x00400000 /* Size of Flash Region 1 */
> > +
> > +#define SSB_PCI_DMA 0x40000000 /* Client Mode sb2pcitranslation2 (1 GB) */
> > +#define SSB_PCI_DMA_SZ 0x40000000 /* Client Mode sb2pcitranslation2 size in bytes */
> > +#define SSB_PCIE_DMA_L32 0x00000000 /* PCIE Client Mode sb2pcitranslation2 (2 ZettaBytes), low 32 bits */
> > +#define SSB_PCIE_DMA_H32 0x80000000 /* PCIE Client Mode sb2pcitranslation2 (2 ZettaBytes), high 32 bits */
> > +#define SSB_EUART (SB_EXTIF_BASE + 0x00800000)
> > +#define SSB_LED (SB_EXTIF_BASE + 0x00900000)
>
> I have just noticed a typo here. That should be SSB_EXTIF_BASE instead
> of SB_EXTIF_BASE.
>

Thanks, I fixed this.

--
Greetings Michael.

2007-07-13 07:09:48

by Holger Schurig

Subject: Re: [patch 1/2] Merge the Sonics Silicon Backplane subsystem

> > +#define SSB_EXTIF_BASE 0x1f000000 /* External Interface
> > +#define SSB_EUART (SB_EXTIF_BASE + 0x00800000)
> > +#define SSB_LED (SB_EXTIF_BASE + 0x00900000)
>
> I have just noticed a typo here. That should be SSB_EXTIF_BASE
> instead of SB_EXTIF_BASE.

Or remove those two defines completely, obviously they are unused.
Otherwise Michael would have get an compiler error.