2007-08-14 11:50:35

by Johannes Berg

Subject: [PATCH 1/4] hostapd: remove enable/disable calls

This isn't really useful since mac80211 always enables the radio
when the interface is brought up.

Signed-off-by: Johannes Berg <[email protected]>

---
hostapd/driver_devicescape.c | 6 ------
1 file changed, 6 deletions(-)

--- hostap.orig/hostapd/driver_devicescape.c 2007-08-14 11:32:34.000000000 +0200
+++ hostap/hostapd/driver_devicescape.c 2007-08-14 11:32:34.000000000 +0200
@@ -2075,9 +2075,6 @@ static void * i802_init(struct hostapd_d
if (i802_init_sockets(drv))
goto failed;

- /* Enable the radio by default. */
- (void) hostap_ioctl_prism2param(drv, PRISM2_PARAM_RADIO_ENABLED, 1);
-
return drv;

failed:
@@ -2091,9 +2088,6 @@ static void i802_deinit(void *priv)
struct i802_driver_data *drv = priv;
struct nl_msg *msg;

- /* Disable the radio. */
- (void) hostap_ioctl_prism2param(drv, PRISM2_PARAM_RADIO_ENABLED, 0);
-
(void) hostapd_set_iface_flags(drv, 0);

if (drv->ioctl_sock >= 0)

--

2007-08-15 03:50:11

by Jouni Malinen

Subject: Re: [PATCH 1/4] hostapd: remove enable/disable calls

On Tue, Aug 14, 2007 at 11:32:55AM +0200, Johannes Berg wrote:
> This isn't really useful since mac80211 always enables the radio
> when the interface is brought up.

Thanks, applied. I think this parameter was originally used (with
another name, though) for disabling the radio when a radar was detected.
The benefit of being able to do this without bringing down the interface
was to not lose IP configuration. Anyway, the radar stuff is very likely
to take a different direction, so getting rid of this parameter should
be fine.

--
Jouni Malinen PGP id EFC895FA