2007-10-23 22:44:46

by Jeff Garzik

Subject: [PATCH 10/12] mac80211: fix warning created by BIT()

Now that BIT() forces unsigned long, this warning appears:

net/mac80211/ieee80211_sta.c: In function =E2=80=98ieee80211_rx_mgmt_as=
soc_resp=E2=80=99:
net/mac80211/ieee80211_sta.c:1187: warning: format =E2=80=98%d=E2=80=99=
expects type =E2=80=98int=E2=80=99, but argument 7 has type =E2=80=98l=
ong unsigned int=E2=80=99

Signed-off-by: Jeff Garzik <[email protected]>
---

diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.=
c
index f7ffeec..bdfd901 100644
--- a/net/mac80211/ieee80211_sta.c
+++ b/net/mac80211/ieee80211_sta.c
@@ -1182,7 +1182,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct n=
et_device *dev,
aid =3D le16_to_cpu(mgmt->u.assoc_resp.aid);
=20
printk(KERN_DEBUG "%s: RX %sssocResp from %s (capab=3D0x%x "
- "status=3D%d aid=3D%d)\n",
+ "status=3D%d aid=3D%ld)\n",
dev->name, reassoc ? "Rea" : "A", print_mac(mac, mgmt->sa),
capab_info, status_code, aid & ~(BIT(15) | BIT(14)));
=20

2007-10-23 23:15:41

by Randy Dunlap

Subject: Re: [PATCH 10/12] mac80211: fix warning created by BIT()

On Tue, 23 Oct 2007 18:36:45 -0400 (EDT) Jeff Garzik wrote:

> Now that BIT() forces unsigned long, this warning appears:
>=20
> net/mac80211/ieee80211_sta.c: In function =E2=80=98ieee80211_rx_mgmt_=
assoc_resp=E2=80=99:
> net/mac80211/ieee80211_sta.c:1187: warning: format =E2=80=98%d=E2=80=99=
expects type =E2=80=98int=E2=80=99, but argument 7 has type =E2=80=98l=
ong unsigned int=E2=80=99

LC_ALL=3DC make ...


> Signed-off-by: Jeff Garzik <[email protected]>
> ---
>=20
> diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_st=
a.c
> index f7ffeec..bdfd901 100644
> --- a/net/mac80211/ieee80211_sta.c
> +++ b/net/mac80211/ieee80211_sta.c
> @@ -1182,7 +1182,7 @@ static void ieee80211_rx_mgmt_assoc_resp(struct=
net_device *dev,
> aid =3D le16_to_cpu(mgmt->u.assoc_resp.aid);
> =20
> printk(KERN_DEBUG "%s: RX %sssocResp from %s (capab=3D0x%x "
> - "status=3D%d aid=3D%d)\n",
> + "status=3D%d aid=3D%ld)\n",
> dev->name, reassoc ? "Rea" : "A", print_mac(mac, mgmt->sa),
> capab_info, status_code, aid & ~(BIT(15) | BIT(14)));
> =20
> -

Patch was submitted yesterday by Johannes Berg, but does need to be
pushed by someone... (like this)


---
~Randy