2007-10-24 19:32:23

by Miguel Botón

Subject: [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function

Add "ssb_pci_set_power_state" function. This allows set the power state=
of a=20
PCI device (for example b44 ethernet device).

diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20
linux-2.6.23.orig/include/linux/ssb/ssb.h
--- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.00000=
0000=20
+0200
+++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.000000000 =
+0200
@@ -402,6 +402,14 @@
{
pci_unregister_driver(driver);
}
+
+/* Set PCI device power state */
+static inline
+void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t state=
)
+{
+ if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI)
+ pci_set_power_state(dev->bus->host_pci, state);
+}
#endif /* CONFIG_SSB_PCIHOST */
=20
=20

--=20
Miguel Bot=F3n

2007-10-24 20:56:23

by Michael Büsch

Subject: Re: [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function

On Wednesday 24 October 2007 21:31:21 Miguel Bot=F3n wrote:
> Add "ssb_pci_set_power_state" function. This allows set the power sta=
te of a=20
> PCI device (for example b44 ethernet device).
>=20
> diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20
> linux-2.6.23.orig/include/linux/ssb/ssb.h
> --- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.000=
000000=20
> +0200
> +++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.00000000=
0 +0200
> @@ -402,6 +402,14 @@
> {
> pci_unregister_driver(driver);
> }
> +
> +/* Set PCI device power state */
> +static inline
> +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t sta=
te)
> +{
> + if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI)
^
Coding style issue.

> + pci_set_power_state(dev->bus->host_pci, state);
> +}
> #endif /* CONFIG_SSB_PCIHOST */
> =20

The rest is acked.

--=20
Greetings Michael.

2007-11-07 02:33:18

by John W. Linville

Subject: Re: [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function

Miguel,

Along with the style point Michael suggested, I'll need you to repost
both this one and the b44 patch with at least a Signed-off-by line.

http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Also, please include the patches as plain text using a mailer that
does not damage whitespace.

Thanks,

John

On Wed, Oct 24, 2007 at 09:31:21PM +0200, Miguel Bot=F3n wrote:
> Add "ssb_pci_set_power_state" function. This allows set the power sta=
te of a=20
> PCI device (for example b44 ethernet device).
>=20
> diff -ruN linux-2.6.23/include/linux/ssb/ssb.h=20
> linux-2.6.23.orig/include/linux/ssb/ssb.h
> --- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.000=
000000=20
> +0200
> +++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.00000000=
0 +0200
> @@ -402,6 +402,14 @@
> {
> pci_unregister_driver(driver);
> }
> +
> +/* Set PCI device power state */
> +static inline
> +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t sta=
te)
> +{
> + if(dev->bus->bustype =3D=3D SSB_BUSTYPE_PCI)
> + pci_set_power_state(dev->bus->host_pci, state);
> +}
> #endif /* CONFIG_SSB_PCIHOST */
> =20
> =20
>=20
> --=20
> Miguel Bot=F3n

--=20
John W. Linville
[email protected]