2007-12-28 13:24:27

by Marcin Juszkiewicz

Subject: [PATCH] Add Linksys WCF11 to hostap driver

=46rom: Marcin Juszkiewicz <[email protected]>

Linksys WCF11 submitted by =C5ngstr=F6m user.

"The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", "Re=
vA",
0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194=20
manfid: 0x0274, 0x3301

Signed-off-by: Marcin Juszkiewicz <[email protected]>

---
drivers/net/wireless/hostap/hostap_cs.c | 4 ++++
1 file changed, 4 insertions(+)

--- linux-2.6.23.orig/drivers/net/wireless/hostap/hostap_cs.c
+++ linux-2.6.23/drivers/net/wireless/hostap/hostap_cs.c
@@ -887,10 +887,14 @@ static struct pcmcia_device_id hostap_cs
"Ver. 1.00",
0x5cd01705, 0x4271660f, 0x9d08ee12),
PCMCIA_DEVICE_PROD_ID123(
"corega", "WL PCCL-11", "ISL37300P",
0xa21501a, 0x59868926, 0xc9049a39),
+ PCMCIA_DEVICE_PROD_ID1234(
+ "The Linksys Group, Inc.", "Wireless Network CF Card", =
"ISL37300P",
+ "RevA",
+ 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),
PCMCIA_DEVICE_NULL
};
MODULE_DEVICE_TABLE(pcmcia, hostap_cs_ids);


--=20
JID: hrw-jabber.org
OpenEmbedded developer/consultant

Resistance Is Useless! (If < 1 ohm)

2007-12-29 04:14:51

by Pavel Roskin

Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver

Hello!

On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:

> + PCMCIA_DEVICE_PROD_ID1234(
> + "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
> + "RevA",
> + 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),

I would prefer that revisions are not used for card identification in
presence of the chip name. It's not like RevB would need another driver
as long as "ISL37300P" is still a part of the PCMCIA ID.
PCMCIA_DEVICE_PROD_ID123 should be enough.

--
Regards,
Pavel Roskin

2007-12-30 15:01:05

by Marcin Juszkiewicz

Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver

Dnia sobota, 29 grudnia 2007, Pavel Roskin napisa=C5=82:
> Hello!
>
> On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:
> > + PCMCIA_DEVICE_PROD_ID1234(
> > + "The Linksys Group, Inc.", "Wireless Network CF
> > Card", "ISL37300P", + "RevA",
> > + 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),
>
> I would prefer that revisions are not used for card identification in
> presence of the chip name. It's not like RevB would need another
> driver as long as "ISL37300P" is still a part of the PCMCIA ID.
> PCMCIA_DEVICE_PROD_ID123 should be enough.

OK - updated patch below:

=46rom: Marcin Juszkiewicz <[email protected]>

Linksys WCF11 submitted by =C3=85ngstr=C3=B6m user.

"The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", "Re=
vA",
0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194=20
manfid: 0x0274, 0x3301

Signed-off-by: Marcin Juszkiewicz <[email protected]>

---
=C2=A0drivers/net/wireless/hostap/hostap_cs.c | =C2=A0 =C2=A03 +++
=C2=A01 file changed, 3 insertions(+)

--- linux-2.6.23.orig/drivers/net/wireless/hostap/hostap_cs.c
+++ linux-2.6.23/drivers/net/wireless/hostap/hostap_cs.c
@@ -887,10 +887,13 @@ static struct pcmcia_device_id hostap_cs
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "Ver. 1.00",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x5cd01705, 0x4=
271660f, 0x9d08ee12),
=C2=A0 =C2=A0 =C2=A0 =C2=A0 PCMCIA_DEVICE_PROD_ID123(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "corega", "WL P=
CCL-11", "ISL37300P",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0xa21501a, 0x59=
868926, 0xc9049a39),
+ =C2=A0 =C2=A0 =C2=A0 PCMCIA_DEVICE_PROD_ID1233(
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "The Linksys Group, =
Inc.", "Wireless Network CF Card", "ISL37300P",
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0xa5f472c2, 0x9c0559=
8d, 0xc9049a39),
=C2=A0 =C2=A0 =C2=A0 =C2=A0 PCMCIA_DEVICE_NULL
=C2=A0};
=C2=A0MODULE_DEVICE_TABLE(pcmcia, hostap_cs_ids);


--=20
JID: hrw-jabber.org
OpenEmbedded developer/consultant

Zemsta jest rozkosz=C4=85 umys=C5=82=C3=B3w miernych, s=C5=82abych i ma=
=C5=82ostkowych. Ale jednak
rozkosz=C4=85 by=C4=87 nie przestaje

2007-12-30 16:39:33

by Pavel Roskin

Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver

Quoting Marcin Juszkiewicz <[email protected]>:

> + PCMCIA_DEVICE_PROD_ID1233(
> + "The Linksys Group, Inc.", "Wireless Network CF
> Card", "ISL37300P",
> + 0xa5f472c2, 0x9c05598d, 0xc9049a39),

Acked-by: Pavel Roskin <[email protected]>

--
Regards,
Pavel Roskin

2008-01-08 21:50:45

by John W. Linville

Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver

On Sun, Dec 30, 2007 at 11:39:31AM -0500, Pavel Roskin wrote:
> Quoting Marcin Juszkiewicz <[email protected]>:
>
>> + PCMCIA_DEVICE_PROD_ID1233(
>> + "The Linksys Group, Inc.", "Wireless Network CF Card",
>> "ISL37300P",
>> + 0xa5f472c2, 0x9c05598d, 0xc9049a39),
>
> Acked-by: Pavel Roskin <[email protected]>

The ID1234 version of this patch is already in Linus' tree. Feel free
to submit a patch that redacts it to the ID123 form.

John
--
John W. Linville
[email protected]