2008-01-26 03:03:39

by Stefano Brivio

[permalink] [raw]
Subject: [PATCH 1/2] rc80211-pid: fix adjusted index check

Compare adjusted indices with real mac80211 indices instead of internal ones
while checking them.

Signed-off-by: Stefano Brivio <[email protected]>
---
John, not sure if this fixes the bug Larry reported, but should applied
anyway.

Index: wireless-2.6/net/mac80211/rc80211_pid_algo.c
===================================================================
--- wireless-2.6.orig/net/mac80211/rc80211_pid_algo.c
+++ wireless-2.6/net/mac80211/rc80211_pid_algo.c
@@ -78,8 +78,13 @@ static int rate_control_pid_shift_adjust
i = j + adj;

if (i < 0)
+ i = r[0].rev_index;
+ if (i > l - 1)
+ i = r[l - 1].rev_index;
+
+ if (r[i].index <= 0)
return r[0].index;
- if (i >= l - 1)
+ if (r[i].index >= l - 1)
return r[l - 1].index;

tmp = i;


--
Ciao
Stefano


2008-01-27 19:39:41

by Stefano Brivio

[permalink] [raw]
Subject: Re: [PATCH 1/2] rc80211-pid: fix adjusted index check

On Sat, 26 Jan 2008 04:02:17 +0100
Stefano Brivio <[email protected]> wrote:

> Compare adjusted indices with real mac80211 indices instead of internal ones
> while checking them.
>
> Signed-off-by: Stefano Brivio <[email protected]>
> ---
> John, not sure if this fixes the bug Larry reported, but should applied
> anyway.

John, please discard this as well.


--
Ciao
Stefano