2008-02-01 01:26:33

by Luis R. Rodriguez

[permalink] [raw]
Subject: [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band

ath5k_copy_channels() wasn't setting the channel's band so all
driver channels had a 2GHz band set. Lets set this.

Signed-off-by: Luis R. Rodriguez <[email protected]>

drivers/net/wireless/ath5k/base.c: Changes-licensed-under: 3-Clause-BSD
---
drivers/net/wireless/ath5k/base.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index bd9c9a8..1e7eeec 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -899,6 +899,8 @@ ath5k_copy_channels(struct ath5k_hw *ah,

/* Write channel info and increment counter */
channels[count].center_freq = freq;
+ channels[count].band = (chfreq == CHANNEL_2GHZ) ?
+ IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;

if ((mode == AR5K_MODE_11A) ||
(mode == AR5K_MODE_11G)) {
--
1.5.2.5



2008-02-01 12:14:57

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band

Your CC lists are somehow messed up... some things are on twice.


> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index bd9c9a8..1e7eeec 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -899,6 +899,8 @@ ath5k_copy_channels(struct ath5k_hw *ah,
>
> /* Write channel info and increment counter */
> channels[count].center_freq = freq;
> + channels[count].band = (chfreq == CHANNEL_2GHZ) ?
> + IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;

No need, cfg80211 will do that when you register the wiphy.

johannes

Attachments:
signature.asc (828.00 B)
This is a digitally signed message part