2008-03-30 21:49:30

by Christian Lamparter

[permalink] [raw]
Subject: [RFC][PATCH 2/2] p54: statistic readback and other changes

This patch brings some of the new features for both
(PCI and USB) devices... unfortunately I don't know if
the readback works on USB.
So please, drop me a line, if it works... or not!

Signed-off-by: Christian Lamparter <[email protected]>


Attachments:
(No filename) (239.00 B)
p54-wlan-stats.diff (18.50 kB)
Download all attachments

2008-03-31 12:29:12

by Christian Lamparter

[permalink] [raw]
Subject: Re: [RFC][PATCH 2/2] p54: statistic readback and other changes

On Monday 31 March 2008 00:02:43 Florian Fainelli wrote:
> Hi Christian,
>
> Le dimanche 30 mars 2008, Chr a ?crit?:
> > This patch brings some of the new features for both
> > (PCI and USB) devices... unfortunately I don't know if
> > the readback works on USB.
>
> @@ -53,10 +53,10 @@ struct pda_entry {
> } __attribute__ ((packed));
>
> struct eeprom_pda_wrap {
> - __le32 magic;
> - __le16 pad;
> - __le16 len;
> - __le32 arm_opcode;
> + u32 magic;
> + u16 pad;
> + u16 len;
> + u32 arm_opcode;
> u8 data[0];
> } __attribute__ ((packed));
Ahh...

> This change will break p54 on big-endian hosts which is something that has
> been fixed few weeks ago.
>
> Will have some test on a prism54 usb device and report back here.
Is it a USB v1 (one with a net2280) or ISL3887?

Regards,
Chr.


Attachments:
(No filename) (796.00 B)
p54-stats-v2.diff (17.68 kB)
Download all attachments

2008-03-31 12:43:03

by Florian Fainelli

[permalink] [raw]
Subject: Re: [RFC][PATCH 2/2] p54: statistic readback and other changes

Le lundi 31 mars 2008, Chr a =E9crit=A0:
> Is it a USB v1 (one with a net2280) or ISL3887?

ISL3887, will post results tomorrow.

>
> Regards,
> Chr.



--=20
Cordialement, Florian Fainelli
------------------------------

2008-03-30 21:57:14

by Florian Fainelli

[permalink] [raw]
Subject: Re: [RFC][PATCH 2/2] p54: statistic readback and other changes

Hi Christian,

Le dimanche 30 mars 2008, Chr a =E9crit=A0:
> This patch brings some of the new features for both
> (PCI and USB) devices... unfortunately I don't know if
> the readback works on USB.

@@ -53,10 +53,10 @@ struct pda_entry {
} __attribute__ ((packed));
=20
struct eeprom_pda_wrap {
- __le32 magic;
- __le16 pad;
- __le16 len;
- __le32 arm_opcode;
+ u32 magic;
+ u16 pad;
+ u16 len;
+ u32 arm_opcode;
u8 data[0];
} __attribute__ ((packed));

This change will break p54 on big-endian hosts which is something that =
has=20
been fixed few weeks ago.

Will have some test on a prism54 usb device and report back here.