2008-03-25 15:29:22

by Johannes Berg

[permalink] [raw]
Subject: is adm8211 capable of sending arbitrary frames?

Hi Michael,

Quick question: it appears that the adm8211 driver pulls out the 802.11
header and instead inserts a custom TX header that only contains one/two
addresses (3/4-addr header format).

This appears to mean that it can send neither QoS frames properly nor
can actually communicate with an AP other than the one it is associated
to. The latter isn't much of a problem, but it seems that the driver
will fall over with QoS AP since it doesn't strip the QoS-data bit from
the frame control. Or does the hardware do that? In any case, mac80211
shouldn't be announcing QoS support for this driver, should it?

johannes


Attachments:
signature.asc (828.00 B)
This is a digitally signed message part

2008-03-31 19:12:56

by Michael Wu

[permalink] [raw]
Subject: Re: is adm8211 capable of sending arbitrary frames?

On Tuesday 25 March 2008 08:56:40 Johannes Berg wrote:
> Quick question: it appears that the adm8211 driver pulls out the 802.11
> header and instead inserts a custom TX header that only contains one/two
> addresses (3/4-addr header format).
>
Yep. It is unfortunate.

> This appears to mean that it can send neither QoS frames properly nor
> can actually communicate with an AP other than the one it is associated
> to. The latter isn't much of a problem, but it seems that the driver
> will fall over with QoS AP since it doesn't strip the QoS-data bit from
> the frame control. Or does the hardware do that? In any case, mac80211
> shouldn't be announcing QoS support for this driver, should it?
>
ADM8211A does not support QoS.. ADM8211B might and ADM8211C does for sure, but
that revision was never sold AFAIK.

At any rate, there is no QoS support for this driver.

-Michael Wu



Attachments:
(No filename) (887.00 B)
signature.asc (194.00 B)
This is a digitally signed message part.
Download all attachments

2008-04-01 12:09:33

by Johannes Berg

[permalink] [raw]
Subject: Re: is adm8211 capable of sending arbitrary frames?


> > This appears to mean that it can send neither QoS frames properly nor
> > can actually communicate with an AP other than the one it is associated
> > to. The latter isn't much of a problem, but it seems that the driver
> > will fall over with QoS AP since it doesn't strip the QoS-data bit from
> > the frame control. Or does the hardware do that? In any case, mac80211
> > shouldn't be announcing QoS support for this driver, should it?
> >
> ADM8211A does not support QoS.. ADM8211B might and ADM8211C does for sure, but
> that revision was never sold AFAIK.

Right.

> At any rate, there is no QoS support for this driver.

Yeah but afaict mac80211 is buggy, it can send QoS frames even if the
driver only has one queue...

johannes


Attachments:
signature.asc (828.00 B)
This is a digitally signed message part