2008-04-06 15:05:43

by Stefano Brivio

Subject: [PATCH] b43legacy: fix bcm4303 crash

This fixes an hard crash which happened upon driver loading on bcm4303 rev.
2 devices.

Signed-off-by: Stefano Brivio <[email protected]>
---
John, this is for 2.6.26.
---
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index e123719..4bc0e8b 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
goto out;

cc = &bus->chipco;
+
+ if (!cc->dev)
+ goto out;
+ if (cc->dev->id.revision < 5)
+ goto out;
+
ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
if (err)


--
Ciao
Stefano

2008-04-06 15:55:08

by Stefano Brivio

Subject: Re: [PATCH] b43legacy: fix bcm4303 crash

On Sun, 6 Apr 2008 17:20:02 +0200
Michael Buesch <[email protected]> wrote:

> On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:
> > This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> > 2 devices.
> >
> > Signed-off-by: Stefano Brivio <[email protected]>
>
> ACK
>
> > ---
> > John, this is for 2.6.26.
>
> Why not 2.6.25?

Sorry, typo. Yes, i meant 2.6.25.


--
Ciao
Stefano

2008-04-06 15:30:00

by Larry Finger

Subject: Re: [PATCH] b43legacy: fix bcm4303 crash

Stefano Brivio wrote:
> This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> 2 devices.
>
> Signed-off-by: Stefano Brivio <[email protected]>
> ---
> John, this is for 2.6.26.

Shouldn't this be for 2.6.25?

Larry

2008-04-06 15:20:52

by Michael Büsch

Subject: Re: [PATCH] b43legacy: fix bcm4303 crash

On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:
> This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> 2 devices.
>
> Signed-off-by: Stefano Brivio <[email protected]>

ACK

> ---
> John, this is for 2.6.26.

Why not 2.6.25?

> ---
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index e123719..4bc0e8b 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
> goto out;
>
> cc = &bus->chipco;
> +
> + if (!cc->dev)
> + goto out;
> + if (cc->dev->id.revision < 5)
> + goto out;
> +
> ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
> err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
> if (err)
>
>
> --
> Ciao
> Stefano
> _______________________________________________
> Bcm43xx-dev mailing list
> [email protected]
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>
>



--
Greetings Michael.