If anyone is interested, the latest compat-wireless tarball fails to
build. It complains about some missing led defines in the rt2x00
directory.
I don't have the exact error messages to hand, but I imagine it's
trivial for someone to type make and find out.
Cheers!
--
Brian
On Sat, 12 Apr 2008 01:23:05 +0100
Brian Morrison <[email protected]> wrote:
> If anyone is interested, the latest compat-wireless tarball fails to
> build. It complains about some missing led defines in the rt2x00
> directory.
>=20
> I don't have the exact error messages to hand, but I imagine it's
> trivial for someone to type make and find out.
>=20
> Cheers!
>=20
=46WIW, the 2008-04-04 and later compat-wireless tarballs fail in the
same way.
The error is:
CC [M] /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x0=
0/rt2x00leds.o
/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt2x00=
leds.c: In function =E2=80=98rt2x00leds_register=E2=80=99:
/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt2x00=
leds.c:171: error: =E2=80=98struct led_classdev=E2=80=99 has no member =
named =E2=80=98blink_set=E2=80=99
/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt2x00=
leds.c:174: error: =E2=80=98struct led_classdev=E2=80=99 has no member =
named =E2=80=98blink_set=E2=80=99
make[4]: *** [/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless=
/rt2x00/rt2x00leds.o] Error 1
make[3]: *** [/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless=
/rt2x00] Error 2
make[2]: *** [/home/bdm/compat-wireless-2008-04-04/drivers/net/wireless=
] Error 2
make[1]: *** [_module_/home/bdm/compat-wireless-2008-04-04] Error 2
make[1]: Leaving directory `/usr/src/kernels/2.6.24.4-64.fc8-x86_64'
make: *** [modules] Error 2
so it looks like a missing define or variable definition.
--=20
Brian
On Mon, 2008-04-14 at 08:59 +0100, Brian Morrison wrote:
> > blink_set is defined in include/linux/led.h in the wireless-testing
> > kernel. I assume it's missing in the kernel you are using.
> >
>
> Looks like it isn't, so possibly there needs to be a way of providing
> missing headers for kernels without their own complete set. Not sure
> how
> that might be done.
I'm leaving it to Luis. Most drivers do something with the LEDs, but
only rt2x00 uses the new interface. Either CONFIG_RT2500PCI_LEDS and
CONFIG_RT2500USB_LEDS should be explicitly disabled (I guess they are
enabled in your kernel), or the drivers should be patched, or the latest
LED code should be backported to the older kernels.
--
Regards,
Pavel Roskin
On Sun, 13 Apr 2008 21:57:13 -0400
Pavel Roskin <[email protected]> wrote:
> Hello!
>=20
> Please don't use bcc: in public emails. Put your addressees to to: a=
nd
> cc: so that nobody wonders why he or she is getting your e-mail.
Yes, it was an error on my part when I accidentally sent the mail back
to myself and then I did a redirect to the list rather than re-address
the mail. Not intentional, but I didn't think it through as I was in a
hurry.
>=20
> On Sat, 2008-04-12 at 10:42 +0100, Brian Morrison wrote:
> > On Sat, 12 Apr 2008 01:23:05 +0100
> > Brian Morrison <[email protected]> wrote:
> >=20
> > > If anyone is interested, the latest compat-wireless tarball fails=
to
> > > build. It complains about some missing led defines in the rt2x00
> > > directory.
> > >=20
> > > I don't have the exact error messages to hand, but I imagine it's
> > > trivial for someone to type make and find out.
>=20
> It would be still useful if you provided the kernel version.
> compat-wireless tries to support the latest kernels, but occasionally
> new changes in the driver can break compatibility with the older
> kernels, and need to be patched.
This was with 2.6.24.4-64.fc8 on Fedora 8.
>=20
> > FWIW, the 2008-04-04 and later compat-wireless tarballs fail in the
> > same way.
> >=20
> > The error is:
> >=20
> > CC
> > [M] /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x=
00/rt2x00leds.o
> > /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt=
2x00leds.c: In function =E2=80=98rt2x00leds_register=E2=80=99:
> > /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt=
2x00leds.c:171: error: =E2=80=98struct led_classdev=E2=80=99 has no mem=
ber named =E2=80=98blink_set=E2=80=99
>=20
> blink_set is defined in include/linux/led.h in the wireless-testing
> kernel. I assume it's missing in the kernel you are using.
>=20
Looks like it isn't, so possibly there needs to be a way of providing
missing headers for kernels without their own complete set. Not sure ho=
w
that might be done.
--=20
Brian Morrison
bdm at fenrir dot org dot uk
"Arguing with an engineer is like wrestling with a pig in the mud;
after a while you realize you are muddy and the pig is enjoying it.=
"
=20
GnuPG key ID DE32E5C5 - http://wwwkeys.uk.pgp.net/pgpnet/wwwkeys.html
On Mon, Apr 14, 2008 at 5:28 AM, Pavel Roskin <[email protected]> wrote:
> On Mon, 2008-04-14 at 08:59 +0100, Brian Morrison wrote:
>
> > > blink_set is defined in include/linux/led.h in the wireless-testing
> > > kernel. I assume it's missing in the kernel you are using.
> > >
> >
> > Looks like it isn't, so possibly there needs to be a way of providing
> > missing headers for kernels without their own complete set. Not sure
> > how
> > that might be done.
>
> I'm leaving it to Luis. Most drivers do something with the LEDs, but
> only rt2x00 uses the new interface. Either CONFIG_RT2500PCI_LEDS and
> CONFIG_RT2500USB_LEDS should be explicitly disabled (I guess they are
> enabled in your kernel), or the drivers should be patched, or the latest
> LED code should be backported to the older kernels.
I'm sorry I've been a bit busy lately moving myself to the West coast,
but today I managed to start catching up. I've updated compat-wireless
to reflect the latest changes and tested a build and load. Please give
it a run and let me know if you still have issues. I'd like to address
them if still present.
Luis
Hello!
Please don't use bcc: in public emails. Put your addressees to to: and
cc: so that nobody wonders why he or she is getting your e-mail.
On Sat, 2008-04-12 at 10:42 +0100, Brian Morrison wrote:
> On Sat, 12 Apr 2008 01:23:05 +0100
> Brian Morrison <[email protected]> wrote:
>=20
> > If anyone is interested, the latest compat-wireless tarball fails t=
o
> > build. It complains about some missing led defines in the rt2x00
> > directory.
> >=20
> > I don't have the exact error messages to hand, but I imagine it's
> > trivial for someone to type make and find out.
It would be still useful if you provided the kernel version.
compat-wireless tries to support the latest kernels, but occasionally
new changes in the driver can break compatibility with the older
kernels, and need to be patched.
> FWIW, the 2008-04-04 and later compat-wireless tarballs fail in the
> same way.
>=20
> The error is:
>=20
> CC
> [M] /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00=
/rt2x00leds.o
> /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt2x=
00leds.c: In function =A1rt2x00leds_register=A2:
> /home/bdm/compat-wireless-2008-04-04/drivers/net/wireless/rt2x00/rt2x=
00leds.c:171: error: =A1struct led_classdev=A2 has no member named =A1b=
link_set=A2
blink_set is defined in include/linux/led.h in the wireless-testing
kernel. I assume it's missing in the kernel you are using.
--=20
Regards,
Pavel Roskin