2008-07-30 02:40:37

by Jack Howarth

[permalink] [raw]
Subject: ath9k and signal level

I was finally able to get the ath9k drivers to work
under 2.6.26-rc1 by using the previous ath9k git patch,
the 16 new ath9k patches, the Berg's proposed skb->cb
patch and the following patch I constructed for ath9k
to mimic the skb->cb changes...

--- linux-2.6.26.x86_64/drivers/net/wireless/ath9k/xmit.c.orig 2008-07-29 19:32
:26.000000000 -0400
+++ linux-2.6.26.x86_64/drivers/net/wireless/ath9k/xmit.c 2008-07-29 20:04
:09.000000000 -0400
@@ -37,6 +37,10 @@

#define OFDM_SIFS_TIME 16

+#ifndef ETH_P_PAE
+#define ETH_P_PAE 0x888E /* Port Access Entity (IEEE 802.1X) */
+#endif /* ETH_P_PAE */
+
static u_int32_t bits_per_symbol[][2] = {
/* 20MHz 40MHz */
{ 26, 54 }, /* 0: BPSK */
@@ -248,7 +252,7 @@
txctl->min_rate = tx_info_priv->min_rate;
} else if (ieee80211_is_data(fc)) {
if (ieee80211_is_nullfunc(fc) ||
- (tx_info->flags & IEEE80211_TX_CTL_EAPOL_FRAME)) {
+ (skb->protocol == cpu_to_be16(ETH_P_PAE))) {
txctl->use_minrate = 1;
txctl->min_rate = tx_info_priv->min_rate;
}
@@ -310,7 +314,7 @@
txctl->keytype = HAL_KEY_TYPE_CLEAR;
txctl->keyix = HAL_TXKEYIX_INVALID;

- if (!(tx_info->flags & IEEE80211_TX_CTL_DO_NOT_ENCRYPT)) {
+ if (tx_info->control.hw_key) {
txctl->keyix = tx_info->control.hw_key->hw_key_idx;
txctl->frmlen += tx_info->control.icv_len;

So far the ath9k driver seems to be working well with one oddity.
I find that the gnome menu applet (using the NetworkManager in Fedora 9)
shows a signal level of zero (even though it recognizes that the connection
exists to the wireless network). Is this a known issue?
Jack
ps Are all 16 patches now applied to the ath9k git?


2008-08-04 18:07:26

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: ath9k and signal level

On Tue, Jul 29, 2008 at 7:40 PM, Jack Howarth <[email protected]> wrote:
> I was finally able to get the ath9k drivers to work
> under 2.6.26-rc1 by using the previous ath9k git patch,
> the 16 new ath9k patches, the Berg's proposed skb->cb
> patch and the following patch I constructed for ath9k
> to mimic the skb->cb changes...

Thanks for the suggested patch. I've integrated a modified version of it.

> So far the ath9k driver seems to be working well with one oddity.
> I find that the gnome menu applet (using the NetworkManager in Fedora 9)
> shows a signal level of zero (even though it recognizes that the connection
> exists to the wireless network). Is this a known issue?

Yes and I've recently added initial patch to add link quality support.

> ps Are all 16 patches now applied to the ath9k git?

Yes, and more.

Luis

2008-08-04 18:16:22

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: ath9k and signal level

On Mon, Aug 4, 2008 at 11:11 AM, Jack Howarth <[email protected]> wrote:
> Luis,
> I noticed. The current ath9k git when built against 2.6.27-rc1-git4
> produces a driver which diplays the signal level in the gnome menu
> bar under Fedora 9. Thanks.

Good to know I hadn't even tested it with a GUI :)

Luis

2008-08-04 18:11:55

by Jack Howarth

[permalink] [raw]
Subject: Re: ath9k and signal level

Luis,
I noticed. The current ath9k git when built against 2.6.27-rc1-git4
produces a driver which diplays the signal level in the gnome menu
bar under Fedora 9. Thanks.
Jack

On Mon, Aug 04, 2008 at 11:07:24AM -0700, Luis R. Rodriguez wrote:
>
> Yes and I've recently added initial patch to add link quality support.
>
>
> Luis