Subject: [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10)


fix this warning i got with last pull

info.c: In function 'print_flag':
info.c:19: warning: format not a string literal and no format arguments
---
info.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/info.c b/info.c
index 9b04719..a9c23a4 100644
--- a/info.c
+++ b/info.c
@@ -16,7 +16,7 @@ static void print_flag(const char *name, int *open)
printf(" (");
else
printf(", ");
- printf(name);
+ printf("%s\n",name);
*open = 1;
}

--
1.6.0.4.766.g6fc4a


2008-11-23 19:58:10

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10)

On Sun, 2008-11-23 at 19:09 +0100, Alejandro Riveira Fernández wrote:
> fix this warning i got with last pull
>
> info.c: In function 'print_flag':
> info.c:19: warning: format not a string literal and no format arguments

The \n you added shouldn't be there, I've committed an equivalent fix.

johannes

Attachments:
signature.asc (836.00 B)
This is a digitally signed message part