2008-12-15 08:38:08

by Jouni Malinen

[permalink] [raw]
Subject: [PATCH] mac80211: Remove radiotap rate-present flag for HT

Since we do not currently report HT rates (MCS index) in radiotap
header for HT rates, we should not claim the rate is present. The rate
octet itself is used as padding in this case, so only the it_present
flag needs to be removed in case of HT rates.

Signed-off-by: Jouni Malinen <[email protected]>
---
net/mac80211/rx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--- wireless-testing.orig/net/mac80211/rx.c 2008-12-15 10:15:17.000000000 +0200
+++ wireless-testing/net/mac80211/rx.c 2008-12-15 10:16:14.000000000 +0200
@@ -123,7 +123,6 @@ ieee80211_add_rx_radiotap_header(struct
/* radiotap header, set always present flags */
rthdr->it_present =
cpu_to_le32((1 << IEEE80211_RADIOTAP_FLAGS) |
- (1 << IEEE80211_RADIOTAP_RATE) |
(1 << IEEE80211_RADIOTAP_CHANNEL) |
(1 << IEEE80211_RADIOTAP_ANTENNA) |
(1 << IEEE80211_RADIOTAP_RX_FLAGS));
@@ -158,8 +157,10 @@ ieee80211_add_rx_radiotap_header(struct
* - short-GI (status->flag & RX_FLAG_SHORT_GI)
*/
*pos = 0;
- } else
+ } else {
+ rthdr->it_present |= (1 << IEEE80211_RADIOTAP_RATE);
*pos = rate->bitrate / 5;
+ }
pos++;

/* IEEE80211_RADIOTAP_CHANNEL */

--
Jouni Malinen PGP id EFC895FA