2009-02-04 10:43:21

by Ismael Ojeda Perez

[permalink] [raw]
Subject: zd1211rw NEW RF Type

Hi, huston we have a problem
I have purchased a tp-link usb wireless device
model : tl-wn422g
i cant work with it because it says there is a new RF type
here its what dmesg shows

[ 503.629054] usbcore: registered new interface driver zd1211rw
[ 522.452184] usb 7-2: new high speed USB device using ehci_hcd and address 5
[ 522.586859] usb 7-2: configuration #1 chosen from 1 choice
[ 522.701176] usb 7-2: reset high speed USB device using ehci_hcd and address 5
[ 522.843643] phy1: Selected rate control algorithm 'pid'
[ 522.846157] zd1211rw 7-2:1.0: phy1
[ 526.888705] firmware: requesting zd1211/zd1211b_ub
[ 526.945146] firmware: requesting zd1211/zd1211b_uphr
[ 526.984508] zd1211rw 7-2:1.0: RF MAXIM_NEW_RF 0x8 is not supported
[ 527.001064] firmware: requesting zd1211/zd1211b_ub
[ 527.007886] firmware: requesting zd1211/zd1211b_uphr

lsusb command shows this
Bus 007 Device 005: ID 0ace:1215 ZyDAS WLA-54L WiFi

im using ubuntu 8.10 linux kernel
2.6.27-7-generic

i whould apreciate any help to get this device working i have some
knowledge of C programming i can try and help you to modify and test
anything you tellme so we can add this new device to the supported
list.

Thank in advance to you all.


2009-02-04 19:43:28

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 4, 2009 at 7:32 PM, Ismael Ojeda Perez
<[email protected]> wrote:

> Thanks for your kind help as you say it was as easy as modifying the
> line and the device is now working perfectly.
> i added just below line 89 the following code
> case MAXIM_NEW_RF:
> r = zd_rf_init_uw2453(rf);
> break;
> Thanks ;) to you all and to the open comunity.
>

Great, there are 3 people/successes... I'll dig up the other two
e-mail addresses and write a proper patch and adding some
signed-offs....

2009-02-04 19:47:14

by Gábor Stefanik

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 4, 2009 at 8:43 PM, Hin-Tak Leung <[email protected]> wrote:
> Great, there are 3 people/successes... I'll dig up the other two
> e-mail addresses and write a proper patch and adding some
> signed-offs....

Tested-bys, perhaps...

--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2009-02-04 15:00:50

by John W. Linville

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 04, 2009 at 10:43:19AM +0000, Ismael Ojeda Perez wrote:
> Hi, huston we have a problem
> I have purchased a tp-link usb wireless device
> model : tl-wn422g
> i cant work with it because it says there is a new RF type
> here its what dmesg shows
>
> [ 503.629054] usbcore: registered new interface driver zd1211rw
> [ 522.452184] usb 7-2: new high speed USB device using ehci_hcd and address 5
> [ 522.586859] usb 7-2: configuration #1 chosen from 1 choice
> [ 522.701176] usb 7-2: reset high speed USB device using ehci_hcd and address 5
> [ 522.843643] phy1: Selected rate control algorithm 'pid'
> [ 522.846157] zd1211rw 7-2:1.0: phy1
> [ 526.888705] firmware: requesting zd1211/zd1211b_ub
> [ 526.945146] firmware: requesting zd1211/zd1211b_uphr
> [ 526.984508] zd1211rw 7-2:1.0: RF MAXIM_NEW_RF 0x8 is not supported
> [ 527.001064] firmware: requesting zd1211/zd1211b_ub
> [ 527.007886] firmware: requesting zd1211/zd1211b_uphr
>
> lsusb command shows this
> Bus 007 Device 005: ID 0ace:1215 ZyDAS WLA-54L WiFi
>
> im using ubuntu 8.10 linux kernel
> 2.6.27-7-generic

Looks like it is still unsupported even in wireless-testing.

> i whould apreciate any help to get this device working i have some
> knowledge of C programming i can try and help you to modify and test
> anything you tellme so we can add this new device to the supported
> list.

Perhaps our inside guy at Atheros (which now owns ZyDAS) can help us
to get some info on this part?

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-02-04 19:32:25

by Ismael Ojeda Perez

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

2009/2/4 Hin-Tak Leung <[email protected]>:
> On Wed, Feb 4, 2009 at 10:43 AM, Ismael Ojeda Perez
> <[email protected]> wrote:
>> Hi, huston we have a problem
>> I have purchased a tp-link usb wireless device
>> model : tl-wn422g
>> i cant work with it because it says there is a new RF type
>> here its what dmesg shows
>
>> [ 526.984508] zd1211rw 7-2:1.0: RF MAXIM_NEW_RF 0x8 is not supported
>
> You probably don't hang out in the right place... two people on the
> sourceforge zd1211 mailing list recently reported that
> MAXIM_NEW_RF=0x08 is just the same as UW2453_RF=0x09 ; and one of
> them has a wn422g and the other wn322g
> (I just went back the mailing list archive and checked), so it is
> likely the same change would work for you:
>
> in drivers/net/wireless/zd1211rw/zd_rf.c, line 89, you see:
>
> --------------------
> case UW2453_RF:
> r = zd_rf_init_uw2453(rf);
> break;
> ---------------------
> Just put an extra line
>
> case MAXIM_NEW_RF:
> either immediately before or immediately after the case UW2453_RF: line.
>
> If it reports success for you, maybe we'll consider putting this in
> properly... I am not the maintainer for that part, so it is likely
> we'll need advice/approval from somebody else for this change to go
> into the kernel.
>

Thanks for your kind help as you say it was as easy as modifying the
line and the device is now working perfectly.
i added just below line 89 the following code
case MAXIM_NEW_RF:
r = zd_rf_init_uw2453(rf);
break;
Thanks ;) to you all and to the open comunity.

2009-02-04 15:50:57

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 4, 2009 at 3:18 PM, John W. Linville <[email protected]> wrote:

>> You probably don't hang out in the right place... two people on the
>> sourceforge zd1211 mailing list recently reported that
>> MAXIM_NEW_RF=0x08 is just the same as UW2453_RF=0x09 ; and one of

> Or someone can send a patch with a report that it is working for them
> and I'll just merge it... :-)

The patch and success report was posted to the sourceforge zd1211
mailing list 2 weeks ago - it is actually in the mailing list archive
( http://sourceforge.net/mailarchive/forum.php?forum_name=zd1211-devs
, 2nd item from top) I think Daniel Drake and a few of the zd1211rw
people are on that list . For slightly controversial(?) change like
this - comparing to just adding vendor+product ids - it is probably
more appropriate if/when one of them decide to put it in...

It is likely that 0x08 is just an older 0x09, so it is probably more
appropriate to put the 0x08 RF id before, rather than after the 0x09
case as in the posted patch to the zd1211 mailing list.

(I have little to do with zd1211rw, just happened to own a zd1211b
device which I run with the vendor (non-rw) driver as my AP, so I
"listen-in" to zd1211-devs ...)

2009-02-04 15:17:29

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 4, 2009 at 10:43 AM, Ismael Ojeda Perez
<[email protected]> wrote:
> Hi, huston we have a problem
> I have purchased a tp-link usb wireless device
> model : tl-wn422g
> i cant work with it because it says there is a new RF type
> here its what dmesg shows

> [ 526.984508] zd1211rw 7-2:1.0: RF MAXIM_NEW_RF 0x8 is not supported

You probably don't hang out in the right place... two people on the
sourceforge zd1211 mailing list recently reported that
MAXIM_NEW_RF=0x08 is just the same as UW2453_RF=0x09 ; and one of
them has a wn422g and the other wn322g
(I just went back the mailing list archive and checked), so it is
likely the same change would work for you:

in drivers/net/wireless/zd1211rw/zd_rf.c, line 89, you see:

--------------------
case UW2453_RF:
r = zd_rf_init_uw2453(rf);
break;
---------------------
Just put an extra line

case MAXIM_NEW_RF:
either immediately before or immediately after the case UW2453_RF: line.

If it reports success for you, maybe we'll consider putting this in
properly... I am not the maintainer for that part, so it is likely
we'll need advice/approval from somebody else for this change to go
into the kernel.

2009-02-04 15:30:50

by John W. Linville

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 04, 2009 at 03:17:26PM +0000, Hin-Tak Leung wrote:
> On Wed, Feb 4, 2009 at 10:43 AM, Ismael Ojeda Perez
> <[email protected]> wrote:
> > Hi, huston we have a problem
> > I have purchased a tp-link usb wireless device
> > model : tl-wn422g
> > i cant work with it because it says there is a new RF type
> > here its what dmesg shows
>
> > [ 526.984508] zd1211rw 7-2:1.0: RF MAXIM_NEW_RF 0x8 is not supported
>
> You probably don't hang out in the right place... two people on the
> sourceforge zd1211 mailing list recently reported that
> MAXIM_NEW_RF=0x08 is just the same as UW2453_RF=0x09 ; and one of
> them has a wn422g and the other wn322g
> (I just went back the mailing list archive and checked), so it is
> likely the same change would work for you:
>
> in drivers/net/wireless/zd1211rw/zd_rf.c, line 89, you see:
>
> --------------------
> case UW2453_RF:
> r = zd_rf_init_uw2453(rf);
> break;
> ---------------------
> Just put an extra line
>
> case MAXIM_NEW_RF:
> either immediately before or immediately after the case UW2453_RF: line.
>
> If it reports success for you, maybe we'll consider putting this in
> properly... I am not the maintainer for that part, so it is likely
> we'll need advice/approval from somebody else for this change to go
> into the kernel.

Or someone can send a patch with a report that it is working for them
and I'll just merge it... :-)

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-02-04 16:15:51

by John W. Linville

[permalink] [raw]
Subject: Re: zd1211rw NEW RF Type

On Wed, Feb 04, 2009 at 03:50:55PM +0000, Hin-Tak Leung wrote:
> On Wed, Feb 4, 2009 at 3:18 PM, John W. Linville <[email protected]> wrote:
>
> >> You probably don't hang out in the right place... two people on the
> >> sourceforge zd1211 mailing list recently reported that
> >> MAXIM_NEW_RF=0x08 is just the same as UW2453_RF=0x09 ; and one of
>
> > Or someone can send a patch with a report that it is working for them
> > and I'll just merge it... :-)
>
> The patch and success report was posted to the sourceforge zd1211
> mailing list 2 weeks ago - it is actually in the mailing list archive
> ( http://sourceforge.net/mailarchive/forum.php?forum_name=zd1211-devs
> , 2nd item from top) I think Daniel Drake and a few of the zd1211rw
> people are on that list . For slightly controversial(?) change like
> this - comparing to just adding vendor+product ids - it is probably
> more appropriate if/when one of them decide to put it in...

This doesn't seem any more contorversial than a USB ID to me...?

> It is likely that 0x08 is just an older 0x09, so it is probably more
> appropriate to put the 0x08 RF id before, rather than after the 0x09
> case as in the posted patch to the zd1211 mailing list.

ACK on the style note.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.