2009-03-02 23:16:17

by Mike Cui

Subject: Bug in iw prevents setting the "cook" monitor flag

There is an off by one error in interface.c of iw that prevents
passing of the cook flag when creating a monitor interface. The fix is
simple:


--- a/interface.c 2009-03-02 15:11:58.748078548 -0800
+++ b/interface.c 2009-03-02 15:12:14.695203787 -0800
@@ -36,7 +36,7 @@ static int parse_mntr_flags(int *_argc,
while (argc) {
int ok = 0;
for (flag = __NL80211_MNTR_FLAG_INVALID;
- flag < NL80211_MNTR_FLAG_MAX; flag++) {
+ flag < NL80211_MNTR_FLAG_MAX + 1; flag++) {
if (strcmp(*argv, mntr_flags[flag]) == 0) {
ok = 1;
/*

2009-03-04 10:04:48

by Kalle Valo

Subject: Re: Bug in iw prevents setting the "cook" monitor flag

"John W. Linville" <[email protected]> writes:

> On Mon, Mar 02, 2009 at 03:16:14PM -0800, Mike Cui wrote:
>> There is an off by one error in interface.c of iw that prevents
>> passing of the cook flag when creating a monitor interface. The fix is
>> simple:
>>
>>
>> --- a/interface.c 2009-03-02 15:11:58.748078548 -0800
>> +++ b/interface.c 2009-03-02 15:12:14.695203787 -0800

[...]

> FWIW, I think I like "x <= Y" instead of "x < Y + 1".

I agree.

> Also, please make sure you are following the guidelines explained here:
>
> http://linux.yyz.us/patch-format.html
>
> In particular, I need a Signed-off-by line from you.

But this is for iw, not for wireless-testing. Or did I miss something?

--
Kalle Valo

2009-03-04 14:15:26

by John W. Linville

Subject: Re: Bug in iw prevents setting the "cook" monitor flag

On Wed, Mar 04, 2009 at 12:04:39PM +0200, Kalle Valo wrote:
> "John W. Linville" <[email protected]> writes:
>
> > On Mon, Mar 02, 2009 at 03:16:14PM -0800, Mike Cui wrote:
> >> There is an off by one error in interface.c of iw that prevents
> >> passing of the cook flag when creating a monitor interface. The fix is
> >> simple:
> >>
> >>
> >> --- a/interface.c 2009-03-02 15:11:58.748078548 -0800
> >> +++ b/interface.c 2009-03-02 15:12:14.695203787 -0800
>
> [...]
>
> > FWIW, I think I like "x <= Y" instead of "x < Y + 1".
>
> I agree.
>
> > Also, please make sure you are following the guidelines explained here:
> >
> > http://linux.yyz.us/patch-format.html
> >
> > In particular, I need a Signed-off-by line from you.
>
> But this is for iw, not for wireless-testing. Or did I miss something?

Ah, you're right... :-) Then I'll let Johannes worry about that.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-03-03 15:00:25

by John W. Linville

Subject: Re: Bug in iw prevents setting the "cook" monitor flag

On Mon, Mar 02, 2009 at 03:16:14PM -0800, Mike Cui wrote:
> There is an off by one error in interface.c of iw that prevents
> passing of the cook flag when creating a monitor interface. The fix is
> simple:
>
>
> --- a/interface.c 2009-03-02 15:11:58.748078548 -0800
> +++ b/interface.c 2009-03-02 15:12:14.695203787 -0800
> @@ -36,7 +36,7 @@ static int parse_mntr_flags(int *_argc,
> while (argc) {
> int ok = 0;
> for (flag = __NL80211_MNTR_FLAG_INVALID;
> - flag < NL80211_MNTR_FLAG_MAX; flag++) {
> + flag < NL80211_MNTR_FLAG_MAX + 1; flag++) {
> if (strcmp(*argv, mntr_flags[flag]) == 0) {
> ok = 1;
> /*

FWIW, I think I like "x <= Y" instead of "x < Y + 1".

Also, please make sure you are following the guidelines explained here:

http://linux.yyz.us/patch-format.html

In particular, I need a Signed-off-by line from you.

Thanks!

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.