2009-03-10 10:29:01

by Nick Kossifidis

Subject: [PATCH 1/3] ath5k: Choose the right initvals for RF2425

* Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413

Signed-off-by: Nick Kossifidis <[email protected]>

---
drivers/net/wireless/ath5k/initvals.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath5k/initvals.c b/drivers/net/wireless/ath5k/initvals.c
index 4488643..61fb621 100644
--- a/drivers/net/wireless/ath5k/initvals.c
+++ b/drivers/net/wireless/ath5k/initvals.c
@@ -1510,8 +1510,8 @@ int ath5k_hw_write_initvals(struct ath5k_hw *ah, u8 mode, bool change_channel)
rf2425_ini_mode_end, mode);

ath5k_hw_ini_registers(ah,
- ARRAY_SIZE(rf2413_ini_common_end),
- rf2413_ini_common_end, change_channel);
+ ARRAY_SIZE(rf2425_ini_common_end),
+ rf2425_ini_common_end, change_channel);

ath5k_hw_ini_registers(ah,
ARRAY_SIZE(rf5112_ini_bbgain),

2009-03-16 02:59:45

by Bob Copeland

Subject: Re: [PATCH 1/3] ath5k: Choose the right initvals for RF2425

On Sun, Mar 15, 2009 at 10:13:39PM +0200, Nick Kossifidis wrote:
> * Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413
>
> Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413
>
> Signed-off-by: Nick Kossifidis <[email protected]>

Nice work, series:

Acked-by: Bob Copeland <[email protected]>

If you do a follow-up cleanup patch, one quick thought I had is that
ee_pwr_cal_[abg] could be an array indexed by mode which might save a
few switch statements - I didn't look at it that hard though.

--
Bob Copeland %% http://www.bobcopeland.com