2009-04-26 12:41:03

by Roel Kluin

Subject: [PATCH] ar9170: wrong test on outlen in ar9170_usb_exec_cmd() ?

remove redundant test: outlen is unsigned

Signed-off-by: Roel Kluin <[email protected]>
---
Maybe you want to test outlen < MAX, but what should MAX be?

diff --git a/drivers/net/wireless/ar9170/usb.c b/drivers/net/wireless/ar9170/usb.c
index fddda47..dfd39e9 100644
--- a/drivers/net/wireless/ar9170/usb.c
+++ b/drivers/net/wireless/ar9170/usb.c
@@ -350,7 +350,7 @@ static int ar9170_usb_exec_cmd(struct ar9170 *ar, enum ar9170_cmd cmd,
goto err_unbuf;
}

- if (outlen >= 0 && aru->readlen != outlen) {
+ if (aru->readlen != outlen) {
err = -EMSGSIZE;
goto err_unbuf;
}

2009-04-26 19:13:32

by Christian Lamparter

Subject: Re: [PATCH] ar9170: wrong test on outlen in ar9170_usb_exec_cmd() ?

On Sunday 26 April 2009 14:40:59 Roel Kluin wrote:
> remove redundant test: outlen is unsigned
>
> Signed-off-by: Roel Kluin <[email protected]>
Acked-by: Christian Lamparter <[email protected]>
> ---
> Maybe you want to test outlen < MAX, but what should MAX be?
Not necessary, there is no hard limit for the size of cmd response.
The firmware will scatter the cmd responses into ~64 bytes packages, if needed.

Regards,
Chr