Subject: [mac80211 ] Wifi Network slownes bisected

LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMjU2DQoNCg0KIEkg
aGF2ZSBhIHJ0MjUwMHBjaSBjYXJkDQoNCiBJIG5vdGljZWQgdGhhdCBteSB3aWZpIGNvbm5lY3Rp
b24gaGFzIHNsb3dlZCB3aGVuIHN0aXRjaGluZw0KZnJvbSAyLjYuMjkuMSB0byAyLjYuMjkuNCAo
aXQgaXMgYWxzbyBzbG93IG9uIDMwLXJjNikNCkFsc28gMi42LjI3ICh1YnVudHUpIGRvZXMgbm90
IHN1ZmZlciBpdC4NCg0KIEkgYmlzZWN0ZWQgYW5kIGNhbWUgdG8gdGhlIGZvbGxvd2luZyBjb21t
aXQgYXMgdGhlIGN1bHByaXQNCg0KIEkgY2FuIHRlc3QgcGF0Y2hlcyBhbmQgaWYgeW91IG5lZWQg
bW9yZSBpbmZvIGp1c3QgYXNrLg0KDQokIGdpdCBiaXNlY3QgZ29vZA0KNjRlMWIwMGM5NzRkZGVh
ZTZhNjBlYmIwMmUxYzQ4NzM3MTkwNWNlYSBpcyBmaXJzdCBiYWQgY29tbWl0DQpjb21taXQgNjRl
MWIwMGM5NzRkZGVhZTZhNjBlYmIwMmUxYzQ4NzM3MTkwNWNlYQ0KQXV0aG9yOiBKb2hhbm5lcyBC
ZXJnIDxqb2hhbm5lc0BzaXBzb2x1dGlvbnMubmV0Pg0KRGF0ZTogICBGcmkgQXByIDI0IDE2OjA1
OjE2IDIwMDkgKzAwMDANCg0KICAgIG1hYzgwMjExOiBmaXggYmFzaWMgcmF0ZSBiaXRtYXAgY2Fs
Y3VsYXRpb24NCiAgICANCiAgICB1cHN0cmVhbSBjb21taXQ6IDdlMDk4NmMxN2Y2OTU5NTJjZTVk
NjFlZDc5M2NlMDQ4YmE5MGE2NjENCiAgICANCiAgICAibWFjODAyMTE6IGZpeCBiYXNpYyByYXRl
cyBzZXR0aW5nIGZyb20gYXNzb2NpYXRpb24gcmVzcG9uc2UiDQogICAgaW50cm9kdWNlZCBhIGNv
cHkvcGFzdGUgZXJyb3IuDQogICAgDQogICAgVW5mb3J0dW5hdGVseSwgdGhpcyBub3QganVzdCBs
ZWFkcyB0byB3cm9uZyBkYXRhIGJlaW5nIHBhc3NlZA0KICAgIHRvIHRoZSBkcml2ZXIgYnV0IGlz
IHJlbW90ZWx5IGV4cGxvaXRhYmxlIGZvciBzb21lIGhhcmR3YXJlIG9yDQogICAgZHJpdmVyIGNv
bWJpbmF0aW9ucy4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBKb2hhbm5lcyBCZXJnIDxqb2hh
bm5lc0BzaXBzb2x1dGlvbnMubmV0Pg0KICAgIFNpZ25lZC1vZmYtYnk6IEpvaG4gVy4gTGludmls
bGUgPGxpbnZpbGxlQHR1eGRyaXZlci5jb20+DQogICAgU2lnbmVkLW9mZi1ieTogQ2hyaXMgV3Jp
Z2h0IDxjaHJpc3dAc291cy1zb2wub3JnPg0KDQo6MDQwMDAwIDA0MDAwMCBlOWU0NzkyMTBiNDZh
ZTQ1ZjljODRiYWRkNTcwMzlkZjQ0ZDQwNzdjDQplYTBiNzE5ZTU0OTg0OTQ0NmU2MmUwNjViMjU3
MGZhYjVhODAxODk1IE0gICAgICBuZXQNCg0KIEJpc2VjdCBMb2cNCiQgZ2l0IGJpc2VjdCBsb2cN
CmdpdCBiaXNlY3Qgc3RhcnQNCiMgYmFkOiBbMTg2ZjliMThiOTRhZmQwYjc1YThlYzFiMzk0YjBm
MTE5ZDQ3OWViNl0gTGludXggMi42LjI5LjQNCmdpdCBiaXNlY3QgYmFkIDE4NmY5YjE4Yjk0YWZk
MGI3NWE4ZWMxYjM5NGIwZjExOWQ0NzllYjYNCiMgZ29vZDogWzhlMGVlNDNiYzJjM2UxOWRiNTZh
NGFkYWE5YTliMDRjZTg4NWNkODRdIExpbnV4IDIuNi4yOQ0KZ2l0IGJpc2VjdCBnb29kIDhlMGVl
NDNiYzJjM2UxOWRiNTZhNGFkYWE5YTliMDRjZTg4NWNkODQNCiMgZ29vZDogW2ZkYTI4ODUzYmM0
YmMwNTNlZjJmYWZiNWM3ZDJhMjZlNmNlNGI0YmZdIEtWTTogRml4IG1pc3Npbmcgc21wIHRsYiBm
bHVzaCBpbiBpbnZscGcNCmdpdCBiaXNlY3QgZ29vZCBmZGEyODg1M2JjNGJjMDUzZWYyZmFmYjVj
N2QyYTI2ZTZjZTRiNGJmDQojIGJhZDogWzc4NDNkY2ZlMTExNWU5NDEyZTZlODM0OTJlMTdmOWM3
NWI1YTA2MmRdIG12NjQzeHhfZXRoOiBPT00gaGFuZGxpbmcgZml4ZXMNCmdpdCBiaXNlY3QgYmFk
IDc4NDNkY2ZlMTExNWU5NDEyZTZlODM0OTJlMTdmOWM3NWI1YTA2MmQNCiMgYmFkOiBbODdiNTll
YWMwOTE0YWI0MDdkZjU3ZmUyM2Q4ODBkY2NkOWE5NDM2ZF0gdmlydGlvLXJuZzogUmVtb3ZlIGZh
bHNlIEJVRyBmb3Igc3B1cmlvdXMgY2FsbGJhY2tzDQpnaXQgYmlzZWN0IGJhZCA4N2I1OWVhYzA5
MTRhYjQwN2RmNTdmZTIzZDg4MGRjY2Q5YTk0MzZkDQojIGdvb2Q6IFsyNDAxNmM3MzVlNjUxZjE3
OTY5MjQzMmYxODE3NjM0OGNhZWI4MmIwXSBzY3NpOiBtcHQ6IHN1cHByZXNzIGRlYnVnb2JqZWN0
cyB3YXJuaW5nDQpnaXQgYmlzZWN0IGdvb2QgMjQwMTZjNzM1ZTY1MWYxNzk2OTI0MzJmMTgxNzYz
NDhjYWViODJiMA0KIyBnb29kOiBbNWM0NzUyNGI1MTRiNWJiMzczMmMzYjg5MzMzOGEyMTBkNjdk
YTNjZF0gdGhpbmtwYWQtYWNwaTogZml4IExFRCBibGlua2luZyB0aHJvdWdoIHRpbWVyIHRyaWdn
ZXINCmdpdCBiaXNlY3QgZ29vZCA1YzQ3NTI0YjUxNGI1YmIzNzMyYzNiODkzMzM4YTIxMGQ2N2Rh
M2NkDQojIGJhZDogW2Q1OTU5OTAwNDhhZDE3YmE3YjBhZDUwNDM4ZWQ2NGY4OGI3YzI1Y2FdIEtW
TTogTU1VOiBkaXNhYmxlIGdsb2JhbCBwYWdlIG9wdGltaXphdGlvbg0KZ2l0IGJpc2VjdCBiYWQg
ZDU5NTk5MDA0OGFkMTdiYTdiMGFkNTA0MzhlZDY0Zjg4YjdjMjVjYQ0KIyBiYWQ6IFs2NGUxYjAw
Yzk3NGRkZWFlNmE2MGViYjAyZTFjNDg3MzcxOTA1Y2VhXSBtYWM4MDIxMTogZml4IGJhc2ljIHJh
dGUgYml0bWFwIGNhbGN1bGF0aW9uDQpnaXQgYmlzZWN0IGJhZCA2NGUxYjAwYzk3NGRkZWFlNmE2
MGViYjAyZTFjNDg3MzcxOTA1Y2VhDQojIGdvb2Q6IFtkMmQ4M2UxZjUyN2I2YjBmYWYxNWQ1NGIy
MmMwMzJlZDU4MTJkMDU0XSBBTFNBOiB1czEyMmw6IGFkZCBzbmRfdXMxMjJsX2ZyZWUoKQ0KZ2l0
IGJpc2VjdCBnb29kIGQyZDgzZTFmNTI3YjZiMGZhZjE1ZDU0YjIyYzAzMmVkNTgxMmQwNTQNCg0K
IA0KDQoNCg0KLS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NClZlcnNpb246IEdudVBHIHYx
LjQuOSAoR05VL0xpbnV4KQ0KDQppUUljQkFFQkNBQUdCUUpLRlhWL0FBb0pFRE80aUVSZVNUQjI2
K1VQL2l4c2ZyNTcxeVZwQ2ttZW1TaE5HSmpGDQpxVGhtdGwrelpMeE8rTzFvazNNL0s1N0R3cHR5
Qk1kZ3gyek9ROVBxUWF0TjJnMmd5WGFGZDNSME1Kbk5yNFNuDQp4UVBFQnRSQUxYSHZDNWIyS3ho
ZmdFQ04xK04zU3NCNENLNWRVeldlcFAvRGMxNnp0MHBFWFUvWlY3UDd2MEV5DQpyOHR2WTR0UFRo
bkhjeS9RZVFMSnVRYWVjaGpCRW14MS9iTitackM1czZ3bGVySEM5U2ovaGQ1WUFwVGx1OWs2DQpv
clJRUkl2MWpRNFVwVTNNcjE2QXg1RXRyc3BMeEJjbmYxQXhZVGxuK0dLc0lnMlExMDhtVE96d1U5
Wkd1NEk4DQpmRWhZYmJwVGhTWXg2RlI2QVB0a3pPZXo0QmtBOTdlVDRmanBGVUtkSWF1Vlkrb21p
VGJlYkxRaXdxd0xER2hXDQpCTEwzeDRqTVdFelNpMXNZR2szcStaNFQ4QkVLcUxzSlZyRVJaWklT
LzFVQ3luTkJDQ3hFbStoVU9LRTN6K0lsDQpRc2RWQlRwNDNjYldoSDJ6bGJnOXNBYitkUTB6eExR
NUpFTjlKaE5Wb1hHa3ozSlVKK3ZZZUkrUjRoSE9OQnpBDQo3bkNIVmd1SE5pdGI5NE0vcmhSZjNQ
VmxmSTQrVVdMS2plZ3c2K015bC9BUW56RGMyK2l1SEsyQTJ2VkRlTU4xDQo3c2FnZEtHaXpvamVT
N01iL2k1V0FYMkUyR3UySFl1Q1doVnpoaUF2M3Yya0NlbTFJRlZseUZrcUZPRjYvcXhODQpmY1ZP
Q0JtZ1JWeVpvZ2ZEZ1FKQThxNGR5cE15b3VXRmFUZDQ4M3Rhd2dsSHpwM3RzY2Q2QWx5dU84VzFq
ZmFuDQp4dXo3RWpmWEU4WUpXYzROS2lKcQ0KPVh5ME8NCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUt
LS0tLQ0K


2009-05-21 16:08:11

by Johannes Berg

[permalink] [raw]
Subject: Re: [mac80211 ] Wifi Network slownes bisected

On Thu, 2009-05-21 at 17:38 +0200, Alejandro Riveira Fernández wrote:

> I noticed that my wifi connection has slowed when stitching
> from 2.6.29.1 to 2.6.29.4 (it is also slow on 30-rc6)
> Also 2.6.27 (ubuntu) does not suffer it.

> $ git bisect good
> 64e1b00c974ddeae6a60ebb02e1c487371905cea is first bad commit
> commit 64e1b00c974ddeae6a60ebb02e1c487371905cea
> Author: Johannes Berg <[email protected]>
> Date: Fri Apr 24 16:05:16 2009 +0000
>
> mac80211: fix basic rate bitmap calculation

Well ... How much did your connection slow down? It is clear that this
commit might possibly slow down your connection, but not by a lot. And
that's only because before we were sending with a higher rate than the
AP allowed us to... If you need the higher speed then set your AP to
G-only to make it include more rates in the basic rate set, that'll
speed up your connection properly.

That's all discounting driver bugs which may exist, of course.

johannes

Attachments:
signature.asc (801.00 B)
This is a digitally signed message part
Subject: Re: [mac80211 ] Wifi Network slownes bisected

El Thu, 21 May 2009 18:08:11 +0200
Johannes Berg <[email protected]> escribió:

> On Thu, 2009-05-21 at 17:38 +0200, Alejandro Riveira Fernández wrote:
>
> > I noticed that my wifi connection has slowed when stitching
> > from 2.6.29.1 to 2.6.29.4 (it is also slow on 30-rc6)
> > Also 2.6.27 (ubuntu) does not suffer it.
>
> > $ git bisect good
> > 64e1b00c974ddeae6a60ebb02e1c487371905cea is first bad commit
> > commit 64e1b00c974ddeae6a60ebb02e1c487371905cea
> > Author: Johannes Berg <[email protected]>
> > Date: Fri Apr 24 16:05:16 2009 +0000
> >
> > mac80211: fix basic rate bitmap calculation
>
> Well ... How much did your connection slow down?

Enough to notice it when connecting through a 3MBit
Adsl connection i.e. with the patch i get 30 40 60 ...
80 kiB maximum without it full 310 KiB so it is an issue
for me (i have inet <-> modem-router <-> myPC only so i can
not test with another pc)


> It is clear that this
> commit might possibly slow down your connection, but not by a lot.

Well it does by a lot avg of 60 KiB vs 300 KiB is lot for me

And that's only because before we were sending with a higher rate than the
> AP allowed us to... If you need the higher speed then set your AP to
> G-only to make it include more rates in the basic rate set, that'll
> speed up your connection properly.

My Ap is set to "mixed" but i connect at G speeds ie iwconfig show 54M or 48M
or 36M but the connection is slow nonetheless
Do you think that would make such a difference (the ap mode)?

Also with the patch i notice weird bumps on connection rates and without it
the connection "feels" more stable

>
> That's all discounting driver bugs which may exist, of course.

well i bisected and the problem is with this commit. Could be
that rt2x00 is doing something wrong with that "rate bitmap" ??
I'm not programmer so i can not check myself

>
> johannes

Alejandro

Thanks for the response...

Attachments:
signature.asc (835.00 B)