From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] Staging: remove rtl8187se driver because of lack of development activities
This driver hasn't seen any real development activities since early July:
257bc86 Staging: rtl8187se: remove unused #include <linu
2035beb param:remove-useless-writable-charp
305409a tree-wide: fix some typos and punctuation in com
b881c6c Staging: fix wireless drivers depends
a010a33 Staging: rtl8187se/rtl8192e/rtl8192su: allow mod
125b181 staging: Add proper selection of WIRELESS_EXT an
b3184e1 Staging: rtl8187se: Fix comment-out-typo
b6ac161 Staging: ARRAY_SIZE changes
so remove it for now.
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
patch is too big for a mailing list so it can be obtained from:
http://www.kernel.org/pub/linux/kernel/people/bart/staging-remove-rtl8187se-driver-because-of-lack-of-development-activities.patch
drivers/staging/Kconfig | 2
drivers/staging/rtl8187se/Kconfig | 7
drivers/staging/rtl8187se/Makefile | 39
drivers/staging/rtl8187se/TODO | 14
drivers/staging/rtl8187se/ieee80211/dot11d.c | 224
drivers/staging/rtl8187se/ieee80211/dot11d.h | 100
drivers/staging/rtl8187se/ieee80211/ieee80211.h | 1496 ----
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c | 247
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.h | 86
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 469 -
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c | 753 --
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c | 295
drivers/staging/rtl8187se/ieee80211/ieee80211_module.c | 210
drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 1548 ----
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c | 3008 --------
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c | 572 -
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 583 -
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c | 749 --
drivers/staging/rtl8187se/r8180.h | 739 --
drivers/staging/rtl8187se/r8180_93cx6.c | 146
drivers/staging/rtl8187se/r8180_93cx6.h | 57
drivers/staging/rtl8187se/r8180_core.c | 4467 -------------
drivers/staging/rtl8187se/r8180_dm.c | 1667 ----
drivers/staging/rtl8187se/r8180_dm.h | 23
drivers/staging/rtl8187se/r8180_hw.h | 573 -
drivers/staging/rtl8187se/r8180_rtl8225.h | 34
drivers/staging/rtl8187se/r8180_rtl8225z2.c | 1089 ---
drivers/staging/rtl8187se/r8180_wx.c | 1589 ----
drivers/staging/rtl8187se/r8180_wx.h | 21
drivers/staging/rtl8187se/r8185b_init.c | 2681 -------
30 files changed, 23488 deletions(-)
Hi Bartolomiej,
Em Mon, 9 Nov 2009 17:31:36 +0100
Bartlomiej Zolnierkiewicz <[email protected]> escreveu:
> From: Bartlomiej Zolnierkiewicz <[email protected]>
> Subject: [PATCH] Staging: remove rtl8187se driver because of lack of development activities
>
> This driver hasn't seen any real development activities since early July:
>
> 257bc86 Staging: rtl8187se: remove unused #include <linu
> 2035beb param:remove-useless-writable-charp
> 305409a tree-wide: fix some typos and punctuation in com
> b881c6c Staging: fix wireless drivers depends
> a010a33 Staging: rtl8187se/rtl8192e/rtl8192su: allow mod
> 125b181 staging: Add proper selection of WIRELESS_EXT an
> b3184e1 Staging: rtl8187se: Fix comment-out-typo
> b6ac161 Staging: ARRAY_SIZE changes
>
> so remove it for now.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
This driver has several points in common with rtl8192* drivers. As I'm
currently working on cleaning up rtl8192u and see what can be done to merge the
common code used by all those realtek drivers, I prefer to keep this driver for
more time at the tree.
The issue I'm currently facing is that we should rearrange the drivers/staging/rtl*
into a common rtl component tree, moving the common components to there. This will
avoid duplicated efforts to cleanup the same code several times, on different
places.
I started working on it this weekend, but I haven't finish it yet.
Cheers,
Mauro
On 11/09/2009 10:56 AM, Mauro Carvalho Chehab wrote:
> Hi Bartolomiej,
>
> Em Mon, 9 Nov 2009 17:31:36 +0100
> Bartlomiej Zolnierkiewicz <[email protected]> escreveu:
>
>> From: Bartlomiej Zolnierkiewicz <[email protected]>
>> Subject: [PATCH] Staging: remove rtl8187se driver because of lack of development activities
>>
>> This driver hasn't seen any real development activities since early July:
>>
>> 257bc86 Staging: rtl8187se: remove unused #include <linu
>> 2035beb param:remove-useless-writable-charp
>> 305409a tree-wide: fix some typos and punctuation in com
>> b881c6c Staging: fix wireless drivers depends
>> a010a33 Staging: rtl8187se/rtl8192e/rtl8192su: allow mod
>> 125b181 staging: Add proper selection of WIRELESS_EXT an
>> b3184e1 Staging: rtl8187se: Fix comment-out-typo
>> b6ac161 Staging: ARRAY_SIZE changes
>>
>> so remove it for now.
>>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
>
> This driver has several points in common with rtl8192* drivers. As I'm
> currently working on cleaning up rtl8192u and see what can be done to merge the
> common code used by all those realtek drivers, I prefer to keep this driver for
> more time at the tree.
>
> The issue I'm currently facing is that we should rearrange the drivers/staging/rtl*
> into a common rtl component tree, moving the common components to there. This will
> avoid duplicated efforts to cleanup the same code several times, on different
> places.
>
> I started working on it this weekend, but I haven't finish it yet.
As I just told Bart (off-list), I started my work on a mainline rtl8187se driver
with the rtl8180 code. There should be plenty of opportunity to set up common
code for the rtl* drivers. I will keep a close eye on your developments.
Larry
On 11/09/2009 10:31 AM, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <[email protected]>
> Subject: [PATCH] Staging: remove rtl8187se driver because of lack of development activities
>
> This driver hasn't seen any real development activities since early July:
>
> 257bc86 Staging: rtl8187se: remove unused #include <linu
> 2035beb param:remove-useless-writable-charp
> 305409a tree-wide: fix some typos and punctuation in com
> b881c6c Staging: fix wireless drivers depends
> a010a33 Staging: rtl8187se/rtl8192e/rtl8192su: allow mod
> 125b181 staging: Add proper selection of WIRELESS_EXT an
> b3184e1 Staging: rtl8187se: Fix comment-out-typo
> b6ac161 Staging: ARRAY_SIZE changes
>
> so remove it for now.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
NACK. I am currently using this driver as a template for the development of a
mainline rtl8187se driver. Removing the staging version would not matter to me,
but it would complicate matters for my tester (Bernhard Schiffner
<[email protected]>). I do not have the hardware, thus I rely on his
help.
Larry