2009-11-19 19:43:51

by Larry Finger

Subject: [PATCH] ssb: Unconditionally log results of core scans

At present, the results of an SSB core scan are only logged when
CONFIG_SSB_DEBUG is "y". As this may not be set in a distro kernel,
it is difficult interpret many problems posted in bug reports or in
help forums.

Signed-off-by: Larry Finger <[email protected]>
---

Index: wireless-testing/drivers/ssb/scan.c
===================================================================
--- wireless-testing.orig/drivers/ssb/scan.c
+++ wireless-testing/drivers/ssb/scan.c
@@ -354,7 +354,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
dev->bus = bus;
dev->ops = bus->ops;

- ssb_dprintk(KERN_INFO PFX
+ printk(KERN_INFO PFX
"Core %d found: %s "
"(cc 0x%03X, rev 0x%02X, vendor 0x%04X)\n",
i, ssb_core_name(dev->id.coreid),

2009-11-19 20:13:33

by Michael Büsch

Subject: Re: [PATCH] ssb: Unconditionally log results of core scans

On Thursday 19 November 2009 20:43:54 Larry Finger wrote:
> At present, the results of an SSB core scan are only logged when
> CONFIG_SSB_DEBUG is "y". As this may not be set in a distro kernel,
> it is difficult interpret many problems posted in bug reports or in
> help forums.
>
> Signed-off-by: Larry Finger <[email protected]>
> ---
>
> Index: wireless-testing/drivers/ssb/scan.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/scan.c
> +++ wireless-testing/drivers/ssb/scan.c
> @@ -354,7 +354,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
> dev->bus = bus;
> dev->ops = bus->ops;
>
> - ssb_dprintk(KERN_INFO PFX
> + printk(KERN_INFO PFX
> "Core %d found: %s "
> "(cc 0x%03X, rev 0x%02X, vendor 0x%04X)\n",
> i, ssb_core_name(dev->id.coreid),
>
>

Please use KERN_DEBUG

--
Greetings, Michael.