I need this in order to get iw to build on Fedora 8.
[greearb@fs2 iw]$ git diff
diff --git a/bitrate.c b/bitrate.c
index 8de8839..9b6defc 100644
--- a/bitrate.c
+++ b/bitrate.c
@@ -1,4 +1,6 @@
#include <errno.h>
+#define __USE_ISOC99
+#include <stdlib.h>
#include "nl80211.h"
#include "iw.h"
Signed-off-by: Ben Greear<[email protected]>
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
On Thu, 2010-09-23 at 16:05 -0700, Ben Greear wrote:
> I notice that you added some code to try to get this working:
>
> #ifndef _ISOC99_SOURCE
> #define _ISOC99_SOURCE
> #endif
>
>
> However, it still will not build for me on Fedora 8. In case I'm doing something
> else strange..were you able to build it on FC8 by any chance?
>
> I can easily carry the fix in my own tree, but thought
> you might want to know...
No, I don't have FC8 anywhere ... Does it build for you with -std=c99?
But that gives me a lot of warnings due to a libnl header file bug
("extern inline").
johannes
Ben Greear <greearb-my8/[email protected]> writes:
> I need this in order to get iw to build on Fedora 8.
>
> [greearb@fs2 iw]$ git diff
> diff --git a/bitrate.c b/bitrate.c
> index 8de8839..9b6defc 100644
> --- a/bitrate.c
> +++ b/bitrate.c
> @@ -1,4 +1,6 @@
> #include <errno.h>
> +#define __USE_ISOC99
This is wrong. You must never define internal glibc macros.
Andreas.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
On Tue, 2010-09-21 at 09:39 -0700, Ben Greear wrote:
> I need this in order to get iw to build on Fedora 8.
>
> [greearb@fs2 iw]$ git diff
> diff --git a/bitrate.c b/bitrate.c
> index 8de8839..9b6defc 100644
> --- a/bitrate.c
> +++ b/bitrate.c
> @@ -1,4 +1,6 @@
> #include <errno.h>
> +#define __USE_ISOC99
> +#include <stdlib.h>
had to add #ifndef guards, but applied it.
johannes
On 09/21/2010 02:34 PM, Johannes Stezenbach wrote:
> On Tue, Sep 21, 2010 at 02:09:57PM -0700, Ben Greear wrote:
>> On 09/21/2010 12:49 PM, Andreas Schwab wrote:
>>> Ben Greear<greearb-my8/[email protected]> writes:
>>>
>>>> I need this in order to get iw to build on Fedora 8.
>>>>
> ...
>>>> +#define __USE_ISOC99
>>>
>>> This is wrong. You must never define internal glibc macros.
>>
>> How about this then?
> ...
>> - tmpf = strtof(argv[i],&end);
>> + tmpf = strtod(argv[i],&end);
> ...
>> Seems you don't have to do anything clever to get strtod to work,
>> and I assume it should cast just fine.
>
> I think to use C99 features like strtof() you need to either
> add -std=c99 to CFLAGS, or #define _ISOC99_SOURCE
> (see /usr/include/features.h).
It seems using strtod would be simpler all around, and might work on
more compilers and even more ancient systems.
Thanks,
Ben
>
> HTH,
> Johannes
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
On 09/24/2010 02:31 AM, Johannes Berg wrote:
> On Thu, 2010-09-23 at 16:05 -0700, Ben Greear wrote:
>> I notice that you added some code to try to get this working:
>>
>> #ifndef _ISOC99_SOURCE
>> #define _ISOC99_SOURCE
>> #endif
>>
>>
>> However, it still will not build for me on Fedora 8. In case I'm doing something
>> else strange..were you able to build it on FC8 by any chance?
>>
>> I can easily carry the fix in my own tree, but thought
>> you might want to know...
>
> No, I don't have FC8 anywhere ... Does it build for you with -std=c99?
> But that gives me a lot of warnings due to a libnl header file bug
> ("extern inline").
Any problem with just changing it to 'strtod' ?
That compiles back at least as far as FC5.
Ben
>
> johannes
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
On 09/21/2010 12:49 PM, Andreas Schwab wrote:
> Ben Greear<greearb-my8/[email protected]> writes:
>
>> I need this in order to get iw to build on Fedora 8.
>>
>> [greearb@fs2 iw]$ git diff
>> diff --git a/bitrate.c b/bitrate.c
>> index 8de8839..9b6defc 100644
>> --- a/bitrate.c
>> +++ b/bitrate.c
>> @@ -1,4 +1,6 @@
>> #include<errno.h>
>> +#define __USE_ISOC99
>
> This is wrong. You must never define internal glibc macros.
How about this then?
diff --git a/bitrate.c b/bitrate.c
index 8de8839..f0d513f 100644
--- a/bitrate.c
+++ b/bitrate.c
@@ -70,7 +70,7 @@ static int handle_bitrates(struct nl80211_state *state,
#endif
else switch (parser_state) {
case S_LEGACY:
- tmpf = strtof(argv[i], &end);
+ tmpf = strtod(argv[i], &end);
if (*end != '\0')
return 1;
if (tmpf < 1 || tmpf > 255 * 2)
Seems you don't have to do anything clever to get strtod to work,
and I assume it should cast just fine.
Thanks,
Ben
>
> Andreas.
>
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
On Fri, 2010-09-24 at 06:45 -0700, Ben Greear wrote:
> On 09/24/2010 02:31 AM, Johannes Berg wrote:
> > On Thu, 2010-09-23 at 16:05 -0700, Ben Greear wrote:
> >> I notice that you added some code to try to get this working:
> >>
> >> #ifndef _ISOC99_SOURCE
> >> #define _ISOC99_SOURCE
> >> #endif
> >>
> >>
> >> However, it still will not build for me on Fedora 8. In case I'm doing something
> >> else strange..were you able to build it on FC8 by any chance?
> >>
> >> I can easily carry the fix in my own tree, but thought
> >> you might want to know...
> >
> > No, I don't have FC8 anywhere ... Does it build for you with -std=c99?
> > But that gives me a lot of warnings due to a libnl header file bug
> > ("extern inline").
>
> Any problem with just changing it to 'strtod' ?
I did that earlier today.
johannes
On Tue, Sep 21, 2010 at 02:09:57PM -0700, Ben Greear wrote:
> On 09/21/2010 12:49 PM, Andreas Schwab wrote:
> >Ben Greear<greearb-my8/[email protected]> writes:
> >
> >>I need this in order to get iw to build on Fedora 8.
> >>
...
> >>+#define __USE_ISOC99
> >
> >This is wrong. You must never define internal glibc macros.
>
> How about this then?
...
> - tmpf = strtof(argv[i], &end);
> + tmpf = strtod(argv[i], &end);
...
> Seems you don't have to do anything clever to get strtod to work,
> and I assume it should cast just fine.
I think to use C99 features like strtof() you need to either
add -std=c99 to CFLAGS, or #define _ISOC99_SOURCE
(see /usr/include/features.h).
HTH,
Johannes
I notice that you added some code to try to get this working:
#ifndef _ISOC99_SOURCE
#define _ISOC99_SOURCE
#endif
However, it still will not build for me on Fedora 8. In case I'm doing something
else strange..were you able to build it on FC8 by any chance?
I can easily carry the fix in my own tree, but thought
you might want to know...
Thanks,
Ben
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com