2010-10-21 17:11:07

by Henry Ptasinski

[permalink] [raw]
Subject: Subject: [PATCH] staging: brcm80211: brcmfmac: Removed codeversion from firmware filenames.

The basename-apiversion-codeversion construction for firmware filenames is not
used by most other firmware files, adds complexity, and is not providing any
value. Rename the firmware files using just basename-apiversion.

Users of the brcmfmac driver will need to update the linux-firmware package
to get the renamed files, or manually rename their installed firmware files.
---
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index 621521b..7f00bc4 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -54,8 +54,8 @@ static struct wl_dev *wl_cfg80211_dev;

u32 wl_dbg_level = WL_DBG_ERR | WL_DBG_INFO;

-#define WL_4329_FW_FILE "brcm/bcm4329-fullmac-4-218-248-5.bin"
-#define WL_4329_NVRAM_FILE "brcm/bcm4329-fullmac-4-218-248-5.txt"
+#define WL_4329_FW_FILE "brcm/bcm4329-fullmac-4.bin"
+#define WL_4329_NVRAM_FILE "brcm/bcm4329-fullmac-4.txt"

/*
** cfg80211_ops api/callback list
--
1.7.1




2010-10-21 18:38:01

by Henry Ptasinski

[permalink] [raw]
Subject: Re: Subject: [PATCH v2] staging: brcm80211: brcmfmac: Removed codeversion from firmware filenames.

The basename-apiversion-codeversion construction for firmware filenames is not
used by most other firmware files, adds complexity, and is not providing any
value. Rename the firmware files using just basename-apiversion.

Users of the brcmfmac driver will need to update the linux-firmware package
to get the renamed files, or manually rename their installed firmware files.

Signed-off-by: Henry Ptasinski <[email protected]>
---
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index 621521b..7f00bc4 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -54,8 +54,8 @@ static struct wl_dev *wl_cfg80211_dev;

u32 wl_dbg_level = WL_DBG_ERR | WL_DBG_INFO;

-#define WL_4329_FW_FILE "brcm/bcm4329-fullmac-4-218-248-5.bin"
-#define WL_4329_NVRAM_FILE "brcm/bcm4329-fullmac-4-218-248-5.txt"
+#define WL_4329_FW_FILE "brcm/bcm4329-fullmac-4.bin"
+#define WL_4329_NVRAM_FILE "brcm/bcm4329-fullmac-4.txt"

/*
** cfg80211_ops api/callback list
--
1.7.1



2010-10-21 18:30:28

by Greg KH

[permalink] [raw]
Subject: Re: Subject: [PATCH] staging: brcm80211: brcmfmac: Removed codeversion from firmware filenames.

On Thu, Oct 21, 2010 at 10:10:55AM -0700, Henry Ptasinski wrote:
> The basename-apiversion-codeversion construction for firmware filenames is not
> used by most other firmware files, adds complexity, and is not providing any
> value. Rename the firmware files using just basename-apiversion.
>
> Users of the brcmfmac driver will need to update the linux-firmware package
> to get the renamed files, or manually rename their installed firmware files.
> ---
> drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

-ENOSIGNED-OFF-BY-LINE :(