2010-10-19 07:31:46

by Bruno Randolf

Subject: [PATCH] iw: Add ibss join parameter for beacon interval

NL80211_ATTR_BEACON_INTERVAL already exists, we just have to use it.

Signed-off-by: Bruno Randolf <[email protected]>
---
ibss.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/ibss.c b/ibss.c
index e85ef1d..e1b6765 100644
--- a/ibss.c
+++ b/ibss.c
@@ -26,6 +26,7 @@ static int join_ibss(struct nl80211_state *state,
int n_rates = 0;
char *value = NULL, *sptr = NULL;
float rate;
+ int bintval;

if (argc < 2)
return 1;
@@ -57,6 +58,15 @@ static int join_ibss(struct nl80211_state *state,
}
}

+ if (argc > 1 && strcmp(argv[0], "bintval") == 0) {
+ argv++;
+ argc--;
+ bintval = strtoul(argv[0], &end, 10);
+ NLA_PUT_U32(msg, NL80211_ATTR_BEACON_INTERVAL, bintval);
+ argv++;
+ argc--;
+ }
+
/* basic rates */
if (argc > 1 && strcmp(argv[0], "basic-rates") == 0) {
argv++;
@@ -108,7 +118,7 @@ COMMAND(ibss, leave, NULL,
NL80211_CMD_LEAVE_IBSS, 0, CIB_NETDEV, leave_ibss,
"Leave the current IBSS cell.");
COMMAND(ibss, join,
- "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] "
+ "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] [bintval <ms>] "
"[basic-rates <rate in Mbps,rate2,...>] [key d:0:abcde]",
NL80211_CMD_JOIN_IBSS, 0, CIB_NETDEV, join_ibss,
"Join the IBSS cell with the given SSID, if it doesn't exist create\n"

2010-10-25 08:29:18

by Johannes Berg

Subject: Re: [PATCH] iw: Add ibss join parameter for beacon interval

On Tue, 2010-10-19 at 16:31 +0900, Bruno Randolf wrote:

> + if (argc > 1 && strcmp(argv[0], "bintval") == 0) {

I'd prefer this to be called just "bi" or fully spelt out.

> NL80211_CMD_LEAVE_IBSS, 0, CIB_NETDEV, leave_ibss,
> "Leave the current IBSS cell.");
> COMMAND(ibss, join,
> - "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] "
> + "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] [bintval <ms>] "

It's not in ms, but TU. *sigh*

johannes

2010-10-26 02:37:12

by Bruno Randolf

Subject: Re: [PATCH] iw: Add ibss join parameter for beacon interval

On Mon October 25 2010 17:26:16 Johannes Berg wrote:
> On Tue, 2010-10-19 at 16:31 +0900, Bruno Randolf wrote:
> > + if (argc > 1 && strcmp(argv[0], "bintval") == 0) {
>
> I'd prefer this to be called just "bi" or fully spelt out.

o.k.

> > NL80211_CMD_LEAVE_IBSS, 0, CIB_NETDEV, leave_ibss,
> > "Leave the current IBSS cell.");
> >
> > COMMAND(ibss, join,
> >
> > - "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] "
> > + "<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] [bintval <ms>] "
>
> It's not in ms, but TU. *sigh*

oh, true. i forgot. will change.

bruno