2010-11-17 21:34:38

by Mark Mentovai

[permalink] [raw]
Subject: [PATCH] cfg80211: fix can_beacon_sec_chan, reenable HT40

This follows wireless-testing 9236d838c920e90708570d9bbd7bb82d30a38130
("cfg80211: fix extension channel checks to initiate communication") and
fixes accidental case fall-through. Without this fix, HT40 is entirely
blocked.

Cc: [email protected]
Cc: Luis R. Rodriguez <[email protected]>
Signed-off-by: Mark Mentovai <[email protected]>
---
net/wireless/chan.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index c8d190d..17cd0c0 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -54,8 +54,10 @@ static bool can_beacon_sec_chan(struct wiphy *wiphy,
switch (channel_type) {
case NL80211_CHAN_HT40PLUS:
diff = 20;
+ break;
case NL80211_CHAN_HT40MINUS:
diff = -20;
+ break;
default:
return false;
}
--
1.7.0.4


2010-11-18 02:40:12

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH] cfg80211: fix can_beacon_sec_chan, reenable HT40

On Wed, Nov 17, 2010 at 01:34:37PM -0800, Mark Mentovai wrote:
> This follows wireless-testing 9236d838c920e90708570d9bbd7bb82d30a38130
> ("cfg80211: fix extension channel checks to initiate communication") and
> fixes accidental case fall-through. Without this fix, HT40 is entirely
> blocked.
>
> Cc: [email protected]
> Cc: Luis R. Rodriguez <[email protected]>
> Signed-off-by: Mark Mentovai <[email protected]>

Thanks,

Acked-by: Luis R. Rodriguez <[email protected]

On your next patch please address John.

Luis