2010-12-03 04:09:39

by Nick Kossifidis

Subject: [PATCH 4/6] ath5k: Fix reporting of RX dma stop failure

* Correctly report failure to stop RX DMA

Signed-off-by: Nick Kossifidis <[email protected]>

---
drivers/net/wireless/ath/ath5k/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c
index 82541fe..0064be7 100644
--- a/drivers/net/wireless/ath/ath5k/dma.c
+++ b/drivers/net/wireless/ath/ath5k/dma.c
@@ -72,7 +72,7 @@ static int ath5k_hw_stop_rx_dma(struct ath5k_hw *ah)
i--)
udelay(100);

- if (i)
+ if (!i)
ATH5K_DBG(ah->ah_sc, ATH5K_DEBUG_DMA,
"failed to stop RX DMA !\n");

2010-12-03 06:35:23

by Sedat Dilek

Subject: Re: [PATCH 4/6] ath5k: Fix reporting of RX dma stop failure

Tested-by: Sedat Dilek <[email protected]>

On Fri, Dec 3, 2010 at 5:09 AM, Nick Kossifidis <[email protected]> wrote:
>  * Correctly report failure to stop RX DMA
>
>  Signed-off-by: Nick Kossifidis <[email protected]>
>
> ---
>  drivers/net/wireless/ath/ath5k/dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c
> index 82541fe..0064be7 100644
> --- a/drivers/net/wireless/ath/ath5k/dma.c
> +++ b/drivers/net/wireless/ath/ath5k/dma.c
> @@ -72,7 +72,7 @@ static int ath5k_hw_stop_rx_dma(struct ath5k_hw *ah)
>                        i--)
>                udelay(100);
>
> -       if (i)
> +       if (!i)
>                ATH5K_DBG(ah->ah_sc, ATH5K_DEBUG_DMA,
>                                "failed to stop RX DMA !\n");
>
>