2011-02-15 19:16:04

by Nickolay Ledovskikh

Subject: [PATCH] ath5k: Right channel setting for ar2317 chip

Patch that fixes right channel setting when running ar2317 based boards.

Signed-off-by: Nikolay Ledovskikh <[email protected]>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 78c26fd..c44111f 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
case AR5K_RF5111:
ret = ath5k_hw_rf5111_channel(ah, channel);
break;
+ case AR5K_RF2317:
case AR5K_RF2425:
ret = ath5k_hw_rf2425_channel(ah, channel);
break;

--
Best regards, Nikolay Ledovskikh.

2011-02-17 00:38:21

by Nick Kossifidis

Subject: Re: [PATCH] ath5k: Right channel setting for ar2317 chip

2011/2/15 Nikolay Ledovskikh <[email protected]>:
> Patch that fixes right channel setting when running ar2317 based boards.
>
> Signed-off-by: Nikolay Ledovskikh <[email protected]>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
>        case AR5K_RF5111:
>                ret = ath5k_hw_rf5111_channel(ah, channel);
>                break;
> +       case AR5K_RF2317:
>        case AR5K_RF2425:
>                ret = ath5k_hw_rf2425_channel(ah, channel);
>                break;
>
> --
> Best regards, Nikolay Ledovskikh.
>

Thanks for catching that, I forgot to add it ;-)

Please resend with a better changelog (eg. "Use correct channel
setting function for AR2317") so that everyone is happy.


--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

2011-02-15 19:50:18

by Jiri Slaby

Subject: Re: [PATCH] ath5k: Right channel setting for ar2317 chip

On 02/15/2011 08:13 PM, Nikolay Ledovskikh wrote:
> Patch that fixes right channel setting when running ar2317 based boards.

I see what it does. However I want to know why. That's what the
changelog should enlighten. I suppose we didn't handled ar2317 and we
want to. And since it is the same as 2425 we may reuse the current code?

> Signed-off-by: Nikolay Ledovskikh <[email protected]>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
> case AR5K_RF5111:
> ret = ath5k_hw_rf5111_channel(ah, channel);
> break;
> + case AR5K_RF2317:
> case AR5K_RF2425:
> ret = ath5k_hw_rf2425_channel(ah, channel);
> break;
>


--
js

2011-02-15 20:51:55

by Nickolay Ledovskikh

Subject: Re: [PATCH] ath5k: Right channel setting for ar2317 chip

Yes, we can reuse the code.
rf2317 handled but not fully, when I tested ahb patch on bullet2 all
seemed to work fine, but it couldn't connect another host (ibss for
example). During an analysis I observed that it's transmitting on
another channel and then I looked into madwifi code and understood
that the problem is in channel setting function.

--
Best regards, Nikolay Ledovskikh.