2011-02-17 04:47:49

by Nickolay Ledovskikh

Subject: [PATCH] ath5k: Correct channel setting for ar2317 chip

Use correct channel setting function for AR2317

Signed-off-by: Nikolay Ledovskikh <[email protected]>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 78c26fd..c44111f 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
case AR5K_RF5111:
ret = ath5k_hw_rf5111_channel(ah, channel);
break;
+ case AR5K_RF2317:
case AR5K_RF2425:
ret = ath5k_hw_rf2425_channel(ah, channel);
break;

--
Best regards, Nikolay Ledovskikh.

2011-02-17 10:25:43

by Jiri Slaby

Subject: Re: [PATCH] ath5k: Correct channel setting for ar2317 chip

On 02/17/2011 05:44 AM, Nikolay Ledovskikh wrote:
> Use correct channel setting function for AR2317

This is as useless as the one before. Why you didn't add there what you
already wrote:
rf2317 handled but not fully, when I tested ahb patch on bullet2 all
seemed to work fine, but it couldn't connect another host (ibss for
example). During an analysis I observed that it's transmitting on
another channel and then I looked into madwifi code and understood that
the problem is in channel setting function.

This is almost perfect and what people want to know. Especially those
who deal with distro bug reports and backport patches to distro kernels...

> Signed-off-by: Nikolay Ledovskikh <[email protected]>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
> case AR5K_RF5111:
> ret = ath5k_hw_rf5111_channel(ah, channel);
> break;
> + case AR5K_RF2317:
> case AR5K_RF2425:
> ret = ath5k_hw_rf2425_channel(ah, channel);
> break;

thanks,
--
js