Subject: [PATCH] ath6kl: Enable force foreground scan in connected state

This was disabled beacause there was a network stall
issue when scan is issued. This issue does not happen
with the new firmware, enable it back.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 8d9fbd4..c50697d 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -639,6 +639,7 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy, struct net_device *ndev,
s8 n_channels = 0;
u16 *channels = NULL;
int ret = 0;
+ u32 force_fg_scan = 0;

if (!ath6kl_cfg80211_ready(ar))
return -EIO;
@@ -700,7 +701,10 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy, struct net_device *ndev,
channels[i] = request->channels[i]->center_freq;
}

- ret = ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, 0,
+ if (test_bit(CONNECTED, &ar->flag))
+ force_fg_scan = 1;
+
+ ret = ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, force_fg_scan,
false, 0, 0, n_channels, channels);
if (ret)
ath6kl_err("wmi_startscan_cmd failed\n");
--
1.7.0.4



2011-10-01 09:52:15

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath6kl: Enable force foreground scan in connected state

On 10/01/2011 12:26 PM, Kalle Valo wrote:
> On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
>> This was disabled beacause there was a network stall
>> issue when scan is issued. This issue does not happen
>> with the new firmware, enable it back.
>
> Please mention the firmware version which has the fix in the commit log.

And I can't apply this before the new firmware available, preferably
even commited to linux-firmware repo.

Kalle

2011-10-01 09:26:34

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath6kl: Enable force foreground scan in connected state

On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> This was disabled beacause there was a network stall
> issue when scan is issued. This issue does not happen
> with the new firmware, enable it back.

Please mention the firmware version which has the fix in the commit log.

Kalle

Subject: Re: [PATCH] ath6kl: Enable force foreground scan in connected state

On Sat, Oct 01, 2011 at 12:50:11PM +0300, Kalle Valo wrote:
> On 10/01/2011 12:26 PM, Kalle Valo wrote:
> > On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> >> This was disabled beacause there was a network stall
> >> issue when scan is issued. This issue does not happen
> >> with the new firmware, enable it back.
> >
> > Please mention the firmware version which has the fix in the commit log.
>
> And I can't apply this before the new firmware available, preferably
> even commited to linux-firmware repo.

Sure, i'm fine with that.

Vasanth

Subject: Re: [PATCH] ath6kl: Enable force foreground scan in connected state

On Sat, Oct 01, 2011 at 04:12:19PM +0530, Vasanthakumar Thiagarajan wrote:
> On Sat, Oct 01, 2011 at 12:50:11PM +0300, Kalle Valo wrote:
> > On 10/01/2011 12:26 PM, Kalle Valo wrote:
> > > On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> > >> This was disabled beacause there was a network stall
> > >> issue when scan is issued. This issue does not happen
> > >> with the new firmware, enable it back.
> > >
> > > Please mention the firmware version which has the fix in the commit log.
> >
> > And I can't apply this before the new firmware available, preferably
> > even commited to linux-firmware repo.
>
> Sure, i'm fine with that.

Actually, the new firmware is sent upstream and merged into
linux-firmware repo just now.

Vasanth