Subject: [PATCH] wpa_supplicant: Set configured auth_algs

In Ap mode, Authentication algorithm is reset in hostapd_config_defaults_bss() and
never be set to the configured one. This would pass the default
auth_algs (OPEN|SHARED) to driver and cause authentication isseues.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
---
wpa_supplicant/ap.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
index d08fc7c..dada412 100644
--- a/wpa_supplicant/ap.c
+++ b/wpa_supplicant/ap.c
@@ -140,6 +140,9 @@ static int wpa_supplicant_conf_ap(struct wpa_supplicant *wpa_s,
bss->ssid.ssid_len = ssid->ssid_len;
bss->ssid.ssid_set = 1;

+ if (ssid->auth_alg)
+ bss->auth_algs = ssid->auth_alg;
+
if (wpa_key_mgmt_wpa_psk(ssid->key_mgmt))
bss->wpa = ssid->proto;
bss->wpa_key_mgmt = ssid->key_mgmt;
--
1.7.0.4



Subject: Re: [PATCH] wpa_supplicant: Set configured auth_algs

On Sat, Nov 12, 2011 at 11:00:06AM +0200, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <[email protected]> writes:
>
> > In Ap mode, Authentication algorithm is reset in
> > hostapd_config_defaults_bss() and never be set to the configured
> > one. This would pass the default auth_algs (OPEN|SHARED) to driver
> > and cause authentication isseues.
>
> Shouldn't you send this to the hostap mailing list?

Oops, forgot it, as the ath6kl patch has a reference to this patch I added
linux-wireless list but missed to add the one meant for hostap. Thanks for
pointing this out.

Vasanth

2011-11-12 09:00:13

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wpa_supplicant: Set configured auth_algs

Vasanthakumar Thiagarajan <[email protected]> writes:

> In Ap mode, Authentication algorithm is reset in
> hostapd_config_defaults_bss() and never be set to the configured
> one. This would pass the default auth_algs (OPEN|SHARED) to driver
> and cause authentication isseues.

Shouldn't you send this to the hostap mailing list?

--
Kalle Valo